Skip to content

[C++] Bump bundled nlohman_json #45991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
assignUser opened this issue Mar 31, 2025 · 3 comments
Closed

[C++] Bump bundled nlohman_json #45991

assignUser opened this issue Mar 31, 2025 · 3 comments
Assignees
@raulcd
Labels
Component: C++ Type: enhancement
Milestone
21.0.0

Comments

@assignUser
Copy link
Member

Describe the enhancement requested

Our version fails to build with CMake 4.0

Component(s)

C++
@raulcd
Copy link
Member

raulcd commented Apr 8, 2025

The latest version for nlohman_json is from late 2023:

There seems to be a discussion to do a new v3.12 release soon, see:

On that release there is a fix for CMake 4 to be able to remove -DCMAKE_POLICY_VERSION_MINIMUM=3.5

We probably want to wait until their v3.12 release is out.

The following diff works if we want to update now and once 3.12 is out:

diff --git a/cpp/thirdparty/versions.txt b/cpp/thirdparty/versions.txt
index 7b5b87bb51..5d0010010e 100644
--- a/cpp/thirdparty/versions.txt
+++ b/cpp/thirdparty/versions.txt
@@ -84,8 +84,8 @@ ARROW_LZ4_BUILD_VERSION=v1.10.0
 ARROW_LZ4_BUILD_SHA256_CHECKSUM=537512904744b35e232912055ccf8ec66d768639ff3abe5788d90d792ec5f48b
 ARROW_MIMALLOC_BUILD_VERSION=v2.0.6
 ARROW_MIMALLOC_BUILD_SHA256_CHECKSUM=9f05c94cc2b017ed13698834ac2a3567b6339a8bde27640df5a1581d49d05ce5
-ARROW_NLOHMANN_JSON_BUILD_VERSION=v3.10.5
-ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM=5daca6ca216495edf89d167f808d1d03c4a4d929cef7da5e10f135ae1540c7e4
+ARROW_NLOHMANN_JSON_BUILD_VERSION=v3.11.3
+ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM=0d8ef5af7f9794e3263480193c491549b2ba6cc74bb018906202ada498a79406
 ARROW_OPENTELEMETRY_BUILD_VERSION=v1.13.0
 ARROW_OPENTELEMETRY_BUILD_SHA256_CHECKSUM=7735cc56507149686e6019e06f588317099d4522480be5f38a2a09ec69af1706

@raulcd raulcd self-assigned this Apr 8, 2025
@kou
Copy link
Member

kou commented Apr 9, 2025

We probably want to wait until their v3.12 release is out.

+1

raulcd added a commit to raulcd/arrow that referenced this issue Apr 11, 2025
@raulcd
apacheGH-45991: [C++] Bump bundled nlohmann_json to v3.12.0
20104a9
@github-actions github-actions bot mentioned this issue Apr 11, 2025
Merged
raulcd added a commit to raulcd/arrow that referenced this issue Apr 11, 2025
@raulcd
apacheGH-45991: [C++] Bump bundled nlohmann_json to v3.12.0
23e4919
kou pushed a commit that referenced this issue Apr 12, 2025
@raulcd
GH-45991: [C++] Bump bundled nlohmann_json to v3.12.0 (#46112)
48fb347 
### Rationale for this change

The version we are currently using is pretty old, from 2021.

### What changes are included in this PR?

Bump the version to latest v3.12.0:
https://github.com/nlohmann/json/tree/v3.12.0

Also remove the requirement to use `-DCMAKE_POLICY_VERSION_MINIMUM` when building it.

### Are these changes tested?

Yes via CI 

### Are there any user-facing changes?

No

* GitHub Issue: #45991

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 21.0.0 milestone Apr 12, 2025
@kou
Copy link
Member

kou commented Apr 12, 2025

Issue resolved by pull request 46112
#46112

@kou kou closed this as completed Apr 12, 2025
lriggs pushed a commit to lriggs/arrow that referenced this issue Apr 15, 2025
@raulcd @lriggs
apacheGH-45991: [C++] Bump bundled nlohmann_json to v3.12.0 (apache#4…
cf15b63 
…6112)

### Rationale for this change

The version we are currently using is pretty old, from 2021.

### What changes are included in this PR?

Bump the version to latest v3.12.0:
https://github.com/nlohmann/json/tree/v3.12.0

Also remove the requirement to use `-DCMAKE_POLICY_VERSION_MINIMUM` when building it.

### Are these changes tested?

Yes via CI 

### Are there any user-facing changes?

No

* GitHub Issue: apache#45991

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Apr 15, 2025
@raulcd @zanmato1984
apacheGH-45991: [C++] Bump bundled nlohmann_json to v3.12.0 (apache#4…
6f8a43c 
…6112)

### Rationale for this change

The version we are currently using is pretty old, from 2021.

### What changes are included in this PR?

Bump the version to latest v3.12.0:
https://github.com/nlohmann/json/tree/v3.12.0

Also remove the requirement to use `-DCMAKE_POLICY_VERSION_MINIMUM` when building it.

### Are these changes tested?

Yes via CI 

### Are there any user-facing changes?

No

* GitHub Issue: apache#45991

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Apr 15, 2025
@raulcd @zanmato1984
apacheGH-45991: [C++] Bump bundled nlohmann_json to v3.12.0 (apache#4…
554fe68 
…6112)

### Rationale for this change

The version we are currently using is pretty old, from 2021.

### What changes are included in this PR?

Bump the version to latest v3.12.0:
https://github.com/nlohmann/json/tree/v3.12.0

Also remove the requirement to use `-DCMAKE_POLICY_VERSION_MINIMUM` when building it.

### Are these changes tested?

Yes via CI 

### Are there any user-facing changes?

No

* GitHub Issue: apache#45991

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcd raulcd

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
21.0.0
Development

No branches or pull requests
3 participants
@kou @raulcd @assignUser