[C++][Parquet] test-conda-cpp-valgrind fails on parquet tests

[raulcd]

Describe the bug, including details regarding any error messages, version, and platform.

The test-conda-cpp-valgrind has been failing for some days on parquet tests (seems related to parquet geospatial):

 The following tests FAILED:
	 88 - parquet-internals-test (Failed)                   parquet-tests unittest
	 90 - parquet-writer-test (Failed)                      parquet-tests unittest

Part of the error log:

==16158== 
==16158== HEAP SUMMARY:
==16158==     in use at exit: 9,874 bytes in 157 blocks
==16158==   total heap usage: 473,942 allocs, 473,785 frees, 5,946,356,088 bytes allocated
==16158== 
==16158== LEAK SUMMARY:
==16158==    definitely lost: 0 bytes in 0 blocks
==16158==    indirectly lost: 0 bytes in 0 blocks
==16158==      possibly lost: 0 bytes in 0 blocks
==16158==    still reachable: 9,874 bytes in 157 blocks
==16158==         suppressed: 0 bytes in 0 blocks
==16158== Reachable blocks (those to which a pointer was found) are not shown.
==16158== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==16158== 
==16158== Use --track-origins=yes to see where uninitialised values come from
==16158== For lists of detected and suppressed errors, rerun with: -s
==16158== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)

      Start 92: parquet-arrow-internals-test
89/96 Test #92: parquet-arrow-internals-test .................   Passed   11.43 sec
      Start 93: parquet-encryption-test
    Test #88: parquet-internals-test .......................***Failed   75.44 sec
==16155== Memcheck, a memory error detector
==16155== Copyright (C) 2002-2024, and GNU GPL'd, by Julian Seward et al.
==16155== Using Valgrind-3.24.0 and LibVEX; rerun with -h for copyright info
==16155== Command: /build/cpp/debug//parquet-internals-test
==16155== 
==16155== Use of uninitialised value of size 8
==16155==    at 0x716528A: _itoa_word (_itoa.c:178)
==16155==    by 0x7180ABD: __vfprintf_internal (vfprintf-internal.c:1516)
==16155==    by 0x7193499: __vsnprintf_internal (vsnprintf.c:114)
==16155==    by 0x716B855: snprintf (snprintf.c:31)
==16155==    by 0x6DC9114: testing::(anonymous namespace)::PrintByteSegmentInObjectTo(unsigned char const*, unsigned long, unsigned long, std::ostream*) (gtest-printers.cc:83)
==16155==    by 0x6DC91AE: testing::(anonymous namespace)::PrintBytesInObjectToImpl(unsigned char const*, unsigned long, std::ostream*) (gtest-printers.cc:100)
==16155==    by 0x6DCAA4C: testing::internal::PrintBytesInObjectTo(unsigned char const*, unsigned long, std::ostream*) (gtest-printers.cc:132)
==16155==    by 0x231DCB: PrintValue<parquet::geospatial::MakeWKBPointTestCase> (gtest-printers.h:316)
==16155==    by 0x231DCB: void testing::internal::PrintWithFallback<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&, std::ostream*) (gtest-printers.h:362)
==16155==    by 0x231DD9: void testing::internal::PrintTo<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&, std::ostream*) (gtest-printers.h:491)
==16155==    by 0x231DE7: Print (gtest-printers.h:883)
==16155==    by 0x231DE7: void testing::internal::UniversalPrint<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&, std::ostream*) (gtest-printers.h:1187)
==16155==    by 0x231E24: Print (gtest-printers.h:1065)
==16155==    by 0x231E24: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > testing::PrintToString<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&) (gtest-printers.h:1225)
==16155==    by 0x2325B6: testing::internal::ParameterizedTestSuiteInfo<parquet::geospatial::MakeWKBPointTestFixture>::RegisterTests() (gtest-param-util.h:600)
==16155==    by 0x6DCA4B5: testing::internal::ParameterizedTestSuiteRegistry::RegisterTests() (gtest-param-util.h:736)
==16155==    by 0x6DF6AD7: testing::internal::UnitTestImpl::RegisterParameterizedTests() (gtest.cc:2837)
==16155==    by 0x6DF6B1E: testing::internal::UnitTestImpl::PostFlagParsingInit() (gtest.cc:5789)
==16155==    by 0x6DF6C15: void testing::internal::InitGoogleTestImpl<char>(int*, char**) (gtest.cc:6871)
==16155==    by 0x6DF6C6B: testing::InitGoogleTest(int*, char**) (gtest.cc:6889)
==16155==    by 0x4DF4861: main (gtest_main.cc:63)
==16155== 
{
   <insert_a_suppression_name_here>
   Memcheck:Value8
   fun:_itoa_word
   fun:__vfprintf_internal
   fun:__vsnprintf_internal
   fun:snprintf
   fun:_ZN7testing12_GLOBAL__N_126PrintByteSegmentInObjectToEPKhmmPSo
   fun:_ZN7testing12_GLOBAL__N_124PrintBytesInObjectToImplEPKhmPSo
   fun:_ZN7testing8internal20PrintBytesInObjectToEPKhmPSo
   fun:PrintValue<parquet::geospatial::MakeWKBPointTestCase>
   fun:_ZN7testing8internal17PrintWithFallbackIN7parquet10geospatial20MakeWKBPointTestCaseEEEvRKT_PSo
   fun:_ZN7testing8internal7PrintToIN7parquet10geospatial20MakeWKBPointTestCaseEEEvRKT_PSo
   fun:Print
   fun:_ZN7testing8internal14UniversalPrintIN7parquet10geospatial20MakeWKBPointTestCaseEEEvRKT_PSo
   fun:Print
   fun:_ZN7testing13PrintToStringIN7parquet10geospatial20MakeWKBPointTestCaseEEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEERKT_
   fun:_ZN7testing8internal26ParameterizedTestSuiteInfoIN7parquet10geospatial23MakeWKBPointTestFixtureEE13RegisterTestsEv
   fun:_ZN7testing8internal30ParameterizedTestSuiteRegistry13RegisterTestsEv
   fun:_ZN7testing8internal12UnitTestImpl26RegisterParameterizedTestsEv
   fun:_ZN7testing8internal12UnitTestImpl19PostFlagParsingInitEv
   fun:_ZN7testing8internal18InitGoogleTestImplIcEEvPiPPT_
   fun:_ZN7testing14InitGoogleTestEPiPPc
   fun:main
}
==16155== Conditional jump or move depends on uninitialised value(s)
==16155==    at 0x716529C: _itoa_word (_itoa.c:178)
==16155==    by 0x7180ABD: __vfprintf_internal (vfprintf-internal.c:1516)
==16155==    by 0x7193499: __vsnprintf_internal (vsnprintf.c:114)
==16155==    by 0x716B855: snprintf (snprintf.c:31)
==16155==    by 0x6DC9114: testing::(anonymous namespace)::PrintByteSegmentInObjectTo(unsigned char const*, unsigned long, unsigned long, std::ostream*) (gtest-printers.cc:83)
==16155==    by 0x6DC91AE: testing::(anonymous namespace)::PrintBytesInObjectToImpl(unsigned char const*, unsigned long, std::ostream*) (gtest-printers.cc:100)
==16155==    by 0x6DCAA4C: testing::internal::PrintBytesInObjectTo(unsigned char const*, unsigned long, std::ostream*) (gtest-printers.cc:132)
==16155==    by 0x231DCB: PrintValue<parquet::geospatial::MakeWKBPointTestCase> (gtest-printers.h:316)
==16155==    by 0x231DCB: void testing::internal::PrintWithFallback<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&, std::ostream*) (gtest-printers.h:362)
==16155==    by 0x231DD9: void testing::internal::PrintTo<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&, std::ostream*) (gtest-printers.h:491)
==16155==    by 0x231DE7: Print (gtest-printers.h:883)
==16155==    by 0x231DE7: void testing::internal::UniversalPrint<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&, std::ostream*) (gtest-printers.h:1187)
==16155==    by 0x231E24: Print (gtest-printers.h:1065)
==16155==    by 0x231E24: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > testing::PrintToString<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&) (gtest-printers.h:1225)
==16155==    by 0x2325B6: testing::internal::ParameterizedTestSuiteInfo<parquet::geospatial::MakeWKBPointTestFixture>::RegisterTests() (gtest-param-util.h:600)
==16155==    by 0x6DCA4B5: testing::internal::ParameterizedTestSuiteRegistry::RegisterTests() (gtest-param-util.h:736)
==16155==    by 0x6DF6AD7: testing::internal::UnitTestImpl::RegisterParameterizedTests() (gtest.cc:2837)
==16155==    by 0x6DF6B1E: testing::internal::UnitTestImpl::PostFlagParsingInit() (gtest.cc:5789)
==16155==    by 0x6DF6C15: void testing::internal::InitGoogleTestImpl<char>(int*, char**) (gtest.cc:6871)
==16155==    by 0x6DF6C6B: testing::InitGoogleTest(int*, char**) (gtest.cc:6889)
==16155==    by 0x4DF4861: main (gtest_main.cc:63)
==16155== 
{
   <insert_a_suppression_name_here>
   Memcheck:Cond
   fun:_itoa_word
   fun:__vfprintf_internal
   fun:__vsnprintf_internal
   fun:snprintf
   fun:_ZN7testing12_GLOBAL__N_126PrintByteSegmentInObjectToEPKhmmPSo
   fun:_ZN7testing12_GLOBAL__N_124PrintBytesInObjectToImplEPKhmPSo
   fun:_ZN7testing8internal20PrintBytesInObjectToEPKhmPSo
   fun:PrintValue<parquet::geospatial::MakeWKBPointTestCase>
   fun:_ZN7testing8internal17PrintWithFallbackIN7parquet10geospatial20MakeWKBPointTestCaseEEEvRKT_PSo
   fun:_ZN7testing8internal7PrintToIN7parquet10geospatial20MakeWKBPointTestCaseEEEvRKT_PSo
   fun:Print
   fun:_ZN7testing8internal14UniversalPrintIN7parquet10geospatial20MakeWKBPointTestCaseEEEvRKT_PSo
   fun:Print
   fun:_ZN7testing13PrintToStringIN7parquet10geospatial20MakeWKBPointTestCaseEEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEERKT_
   fun:_ZN7testing8internal26ParameterizedTestSuiteInfoIN7parquet10geospatial23MakeWKBPointTestFixtureEE13RegisterTestsEv
   fun:_ZN7testing8internal30ParameterizedTestSuiteRegistry13RegisterTestsEv
   fun:_ZN7testing8internal12UnitTestImpl26RegisterParameterizedTestsEv
   fun:_ZN7testing8internal12UnitTestImpl19PostFlagParsingInitEv
   fun:_ZN7testing8internal18InitGoogleTestImplIcEEvPiPPT_
   fun:_ZN7testing14InitGoogleTestEPiPPc
   fun:main
}
==16155== Conditional jump or move depends on uninitialised value(s)
==16155==    at 0x71815C3: __vfprintf_internal (vfprintf-internal.c:1516)
==16155==    by 0x7193499: __vsnprintf_internal (vsnprintf.c:114)
==16155==    by 0x716B855: snprintf (snprintf.c:31)
==16155==    by 0x6DC9114: testing::(anonymous namespace)::PrintByteSegmentInObjectTo(unsigned char const*, unsigned long, unsigned long, std::ostream*) (gtest-printers.cc:83)
==16155==    by 0x6DC91AE: testing::(anonymous namespace)::PrintBytesInObjectToImpl(unsigned char const*, unsigned long, std::ostream*) (gtest-printers.cc:100)
==16155==    by 0x6DCAA4C: testing::internal::PrintBytesInObjectTo(unsigned char const*, unsigned long, std::ostream*) (gtest-printers.cc:132)
==16155==    by 0x231DCB: PrintValue<parquet::geospatial::MakeWKBPointTestCase> (gtest-printers.h:316)
==16155==    by 0x231DCB: void testing::internal::PrintWithFallback<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&, std::ostream*) (gtest-printers.h:362)
==16155==    by 0x231DD9: void testing::internal::PrintTo<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&, std::ostream*) (gtest-printers.h:491)
==16155==    by 0x231DE7: Print (gtest-printers.h:883)
==16155==    by 0x231DE7: void testing::internal::UniversalPrint<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&, std::ostream*) (gtest-printers.h:1187)
==16155==    by 0x231E24: Print (gtest-printers.h:1065)
==16155==    by 0x231E24: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > testing::PrintToString<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&) (gtest-printers.h:1225)
==16155==    by 0x2325B6: testing::internal::ParameterizedTestSuiteInfo<parquet::geospatial::MakeWKBPointTestFixture>::RegisterTests() (gtest-param-util.h:600)
==16155==    by 0x6DCA4B5: testing::internal::ParameterizedTestSuiteRegistry::RegisterTests() (gtest-param-util.h:736)
==16155==    by 0x6DF6AD7: testing::internal::UnitTestImpl::RegisterParameterizedTests() (gtest.cc:2837)
==16155==    by 0x6DF6B1E: testing::internal::UnitTestImpl::PostFlagParsingInit() (gtest.cc:5789)
==16155==    by 0x6DF6C15: void testing::internal::InitGoogleTestImpl<char>(int*, char**) (gtest.cc:6871)
==16155==    by 0x6DF6C6B: testing::InitGoogleTest(int*, char**) (gtest.cc:6889)
==16155==    by 0x4DF4861: main (gtest_main.cc:63)
==16155== 
{
   <insert_a_suppression_name_here>
   Memcheck:Cond
   fun:__vfprintf_internal
   fun:__vsnprintf_internal
   fun:snprintf
   fun:_ZN7testing12_GLOBAL__N_126PrintByteSegmentInObjectToEPKhmmPSo
   fun:_ZN7testing12_GLOBAL__N_124PrintBytesInObjectToImplEPKhmPSo
   fun:_ZN7testing8internal20PrintBytesInObjectToEPKhmPSo
   fun:PrintValue<parquet::geospatial::MakeWKBPointTestCase>
   fun:_ZN7testing8internal17PrintWithFallbackIN7parquet10geospatial20MakeWKBPointTestCaseEEEvRKT_PSo
   fun:_ZN7testing8internal7PrintToIN7parquet10geospatial20MakeWKBPointTestCaseEEEvRKT_PSo
   fun:Print
   fun:_ZN7testing8internal14UniversalPrintIN7parquet10geospatial20MakeWKBPointTestCaseEEEvRKT_PSo
   fun:Print
   fun:_ZN7testing13PrintToStringIN7parquet10geospatial20MakeWKBPointTestCaseEEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEERKT_
   fun:_ZN7testing8internal26ParameterizedTestSuiteInfoIN7parquet10geospatial23MakeWKBPointTestFixtureEE13RegisterTestsEv
   fun:_ZN7testing8internal30ParameterizedTestSuiteRegistry13RegisterTestsEv
   fun:_ZN7testing8internal12UnitTestImpl26RegisterParameterizedTestsEv
   fun:_ZN7testing8internal12UnitTestImpl19PostFlagParsingInitEv
   fun:_ZN7testing8internal18InitGoogleTestImplIcEEvPiPPT_
   fun:_ZN7testing14InitGoogleTestEPiPPc
   fun:main
}
==16155== Conditional jump or move depends on uninitialised value(s)
==16155==    at 0x7180C05: __vfprintf_internal (vfprintf-internal.c:1516)
==16155==    by 0x7193499: __vsnprintf_internal (vsnprintf.c:114)
==16155==    by 0x716B855: snprintf (snprintf.c:31)
==16155==    by 0x6DC9114: testing::(anonymous namespace)::PrintByteSegmentInObjectTo(unsigned char const*, unsigned long, unsigned long, std::ostream*) (gtest-printers.cc:83)
==16155==    by 0x6DC91AE: testing::(anonymous namespace)::PrintBytesInObjectToImpl(unsigned char const*, unsigned long, std::ostream*) (gtest-printers.cc:100)
==16155==    by 0x6DCAA4C: testing::internal::PrintBytesInObjectTo(unsigned char const*, unsigned long, std::ostream*) (gtest-printers.cc:132)
==16155==    by 0x231DCB: PrintValue<parquet::geospatial::MakeWKBPointTestCase> (gtest-printers.h:316)
==16155==    by 0x231DCB: void testing::internal::PrintWithFallback<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&, std::ostream*) (gtest-printers.h:362)
==16155==    by 0x231DD9: void testing::internal::PrintTo<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&, std::ostream*) (gtest-printers.h:491)
==16155==    by 0x231DE7: Print (gtest-printers.h:883)
==16155==    by 0x231DE7: void testing::internal::UniversalPrint<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&, std::ostream*) (gtest-printers.h:1187)
==16155==    by 0x231E24: Print (gtest-printers.h:1065)
==16155==    by 0x231E24: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > testing::PrintToString<parquet::geospatial::MakeWKBPointTestCase>(parquet::geospatial::MakeWKBPointTestCase const&) (gtest-printers.h:1225)
==16155==    by 0x2325B6: testing::internal::ParameterizedTestSuiteInfo<parquet::geospatial::MakeWKBPointTestFixture>::RegisterTests() (gtest-param-util.h:600)
==16155==    by 0x6DCA4B5: testing::internal::ParameterizedTestSuiteRegistry::RegisterTests() (gtest-param-util.h:736)
==16155==    by 0x6DF6AD7: testing::internal::UnitTestImpl::RegisterParameterizedTests() (gtest.cc:2837)
==16155==    by 0x6DF6B1E: testing::internal::UnitTestImpl::PostFlagParsingInit() (gtest.cc:5789)
==16155==    by 0x6DF6C15: void testing::internal::InitGoogleTestImpl<char>(int*, char**) (gtest.cc:6871)
==16155==    by 0x6DF6C6B: testing::InitGoogleTest(int*, char**) (gtest.cc:6889)
==16155==    by 0x4DF4861: main (gtest_main.cc:63)
==16155== 
{
   <insert_a_suppression_name_here>
   Memcheck:Cond
   fun:__vfprintf_internal
   fun:__vsnprintf_internal
   fun:snprintf
   fun:_ZN7testing12_GLOBAL__N_126PrintByteSegmentInObjectToEPKhmmPSo
   fun:_ZN7testing12_GLOBAL__N_124PrintBytesInObjectToImplEPKhmPSo
   fun:_ZN7testing8internal20PrintBytesInObjectToEPKhmPSo
   fun:PrintValue<parquet::geospatial::MakeWKBPointTestCase>
   fun:_ZN7testing8internal17PrintWithFallbackIN7parquet10geospatial20MakeWKBPointTestCaseEEEvRKT_PSo
   fun:_ZN7testing8internal7PrintToIN7parquet10geospatial20MakeWKBPointTestCaseEEEvRKT_PSo
   fun:Print
   fun:_ZN7testing8internal14UniversalPrintIN7parquet10geospatial20MakeWKBPointTestCaseEEEvRKT_PSo
   fun:Print
   fun:_ZN7testing13PrintToStringIN7parquet10geospatial20MakeWKBPointTestCaseEEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEERKT_
   fun:_ZN7testing8internal26ParameterizedTestSuiteInfoIN7parquet10geospatial23MakeWKBPointTestFixtureEE13RegisterTestsEv
   fun:_ZN7testing8internal30ParameterizedTestSuiteRegistry13RegisterTestsEv
   fun:_ZN7testing8internal12UnitTestImpl26RegisterParameterizedTestsEv
   fun:_ZN7testing8internal12UnitTestImpl19PostFlagParsingInitEv
   fun:_ZN7testing8internal18InitGoogleTestImplIcEEvPiPPT_
   fun:_ZN7testing14InitGoogleTestEPiPPc
   fun:main
}
Running main() from /build/cpp/_deps/googletest-src/googletest/src/gtest_main.cc

Component(s)

Parquet, C++

[raulcd]

I am unsure whether the failure on test-ubuntu-22.04-cpp-20 might be related but its segfaulting also on Parquet GeoArrow:

[ RUN      ] TestConvertArrowSchema.ParquetGeoArrowCrsLonLat
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Running '/build/cpp/debug/parquet-arrow-test' produced core dump at '/tmp/core.parquet-arrow-t.44624', printing backtrace:
[New LWP 44624]
[New LWP 44650]
[New LWP 44974]
[New LWP 44975]
[New LWP 44977]
[New LWP 44978]
[New LWP 44976]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/build/cpp/debug/parquet-arrow-test'.
Program terminated with signal SIGSEGV, Segmentation fault.

We can open a separate issue if not related.

cc @paleolimbot @pitrou @wgtmac

[paleolimbot]

Thank you for passing this on! I'll look into this today.

[paleolimbot]

Issue resolved by pull request 46320
#46320