Console session should be marked as `acquired` when accessed through the browser.

[DaanHoogland]

can you explain this @bernardodemarco ?

ok, the problem is that a console created in the ui is not marked as active somehow.

@DaanHoogland, yes. I've already investigated this behavior when I was developing this patch. The console session is (or should be) marked as acquired when the user actually access the console through the browser.

note how removed field is not present in the newer session but still it is not shown without activeonly=false.

That happens because it is not marked as acquired. If the session has been acquired and has not been removed, then it is active. If the session has not been acquired, it is considered as inactive. If it has been removed, it is also considered as inactive.

Originally posted by @bernardodemarco in #11016 (comment)

[bernardodemarco]

@DaanHoogland, I was not able to reproduce the issue in my environment. After accessing a console through the browser, the client_address and acquired fields are populated. The following method is executed to achieve that:

cloudstack/engine/schema/src/main/java/com/cloud/vm/dao/ConsoleSessionDaoImpl.java

Lines 64 to 70 in 16c60c7

	@Override
	public void acquireSession(String sessionUuid, String clientAddress) {
	ConsoleSessionVO consoleSessionVO = findByUuid(sessionUuid);
	consoleSessionVO.setAcquired(new Date());
	consoleSessionVO.setClientAddress(clientAddress);
	update(consoleSessionVO.getId(), consoleSessionVO);
	}

[DaanHoogland]

ok, maybe a delay in my browser/version? I’ll try to reproduce.