Skip to content

Commit a1ba817

Browse files
committed
Update timezone handling to use Option type for clearer defaults
1 parent c666c79 commit a1ba817

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

datafusion/functions/src/datetime/common.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -976,7 +976,7 @@ mod tests {
976976
#[test]
977977
fn from_config_blank_timezone_defaults_to_utc() {
978978
let mut config = ConfigOptions::default();
979-
config.execution.time_zone.clear();
979+
config.execution.time_zone = None;
980980

981981
let timezone = ConfiguredTimeZone::from_config(&config);
982982
assert_eq!(timezone, ConfiguredTimeZone::utc());

datafusion/functions/src/datetime/to_timestamp.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -852,7 +852,7 @@ mod tests {
852852
#[test]
853853
fn to_timestamp_respects_execution_timezone() -> Result<()> {
854854
let mut options = ConfigOptions::default();
855-
options.execution.time_zone = "-05:00".into();
855+
options.execution.time_zone = Some("-05:00".to_string());
856856
let udf = ToTimestampFunc::new_with_config(&options);
857857
let field = Field::new("arg", Utf8, true).into();
858858

@@ -885,7 +885,7 @@ mod tests {
885885
Field::new("f", Timestamp(Nanosecond, None), true).into();
886886

887887
let mut options = ConfigOptions::default();
888-
options.execution.time_zone = "Invalid/Timezone".into();
888+
options.execution.time_zone = Some("Invalid/Timezone".to_string());
889889
let udf = ToTimestampFunc::new_with_config(&options);
890890

891891
let explicit_args = datafusion_expr::ScalarFunctionArgs {
@@ -938,7 +938,7 @@ mod tests {
938938
Field::new("f", Timestamp(Nanosecond, None), true).into();
939939

940940
let mut options = ConfigOptions::default();
941-
options.execution.time_zone = "Invalid/Timezone".into();
941+
options.execution.time_zone = Some("Invalid/Timezone".to_string());
942942
let udf = ToTimestampFunc::new_with_config(&options);
943943

944944
let make_args = |value: &str, format: &str| datafusion_expr::ScalarFunctionArgs {

0 commit comments

Comments
 (0)