Skip to content

Optimize planning speed / stop cloning Strings / Fields so much #18413

@alamb

Description

@alamb

Is your feature request related to a problem or challenge?

While I was working on #18337 I saw a lot of
string copying happening when calculating qualified names and types and fields.

For example, in Expr::to_field there are clones all over the place:

let field = expr.to_field(schema).map(|(_, f)| f.as_ref().clone())?;

There are also several places where the field names are copied at least twice

Describe the solution you'd like

Stop copying so much

Describe alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions