-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Description
Search before asking
- I had searched in the issues and found no similar issues.
What happened
After upgrading to 3.3.1, we had problems with imports of existing workflows + creation of new workflows that contain the Conditions task. When trying to save a new workflow with a conditions task, the following error message occurs "workflow node controlleer-get-task-labels parameter invalid".
What you expected to happen
The workflows with the Conditions task saves succesfully.
How to reproduce
- create a new workflow containing a conditions task, filling in only required fields with red star
- try to save to workflow
Anything else
In the api pod, the following error also occurs "o.a.d.a.s.i.WorkflowDefinitionServiceImpl:[469] - Generate task definition list failed, the given task definition parameter is invalided,". This seems the result of added parameter validation of ConditionsParameters in the 3.3.0 alpha version. Where in the current version the field dependItemList needs to have entries in the list.
This extra required field is not marked as required in the UI (see "Add pre task check condition"-field in conditions task), but is required in the backend.
Either the field in the UI needs to be marked as required, or the backend validation needs to be adjusted, but I do not have the knowledge to know what the aim of these changes were. If the decided change is editing the backend validation, I could create a PR for this bug.
Version
3.3.1
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct