Remove maven.twttr repo from pom (#17797)

remove usage of dependency:go-offline from build scripts - as it tries to download excluded artifacts

---------

Co-authored-by: Zoltan Haindrich <[email protected]>

Author: kfaraz

.github/workflows/cron-job-its.yml

@@ -127,7 +127,7 @@ jobs:
           cache: maven
 
       - name: maven build # needed to rebuild incase of maven snapshot resolution fails
-        run: mvn clean install dependency:go-offline -P dist -P skip-static-checks,skip-tests -Dmaven.javadoc.skip=true -Dcyclonedx.skip=true -Dweb.console.skip=true
+        run: mvn clean install -P dist -P skip-static-checks,skip-tests -Dmaven.javadoc.skip=true -Dcyclonedx.skip=true -Dweb.console.skip=true
 
       - name: security vulnerabilities check
         run: |

integration-tests/script/setup_druid_on_k8s.sh

@@ -26,7 +26,7 @@ cp -r client_tls docker/client_tls
 cd ..
 
 # Build Docker images for pods
-mvn -B -ff -q dependency:go-offline \
+mvn -B -ff -q \
       install \
       -Pdist,bundle-contrib-exts \
       -Pskip-static-checks,skip-tests \

it.sh

@@ -229,7 +229,7 @@ case $CMD in
     usage
     ;;
   "ci" )
-    mvn -q clean install dependency:go-offline -P dist $MAVEN_IGNORE -T1C
+    mvn -q clean install -P dist $MAVEN_IGNORE -T1C
     ;;
   "build" )
     mvn -B clean install -P dist $MAVEN_IGNORE -T1.0C $*

pom.xml

@@ -293,16 +293,6 @@
                <enabled>false</enabled>
             </snapshots>
         </repository>
-
-        <!--
-        maven-dependency-plugin:3.1.2 seems to have updated HTTP repository access behavior.
-        We get the following error "Blocked mirror for repositories: [twitter (http://maven.twttr.com, default, releases+snapshots)]"
-        The suggested action step is to add the mirror: https://maven.apache.org/docs/3.8.1/release-notes.html#how-to-fix-when-i-get-a-http-repository-blocked
-        -->
-        <repository>
-            <id>twitter</id>
-            <url>https://maven.twttr.com</url>
-        </repository>
     </repositories>
 
     <pluginRepositories>