-
Notifications
You must be signed in to change notification settings - Fork 963
feat: logger module refactorization #2838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c211dba
to
ffdd040
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- go.mod: Language not supported
Please check the ci failure. |
caused by gost, pr dubbogo/gost#122 need to be merged |
CI must pass, we need to ensure the quality of the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
improve comment Co-authored-by: Copilot <[email protected]>
a736da4
to
d6a72f0
Compare
…che#2850) (apache#2878) * update golangci-lint to v2 and fix the issues detected by it * change .github\workflows\golangci-lint.yml * change .github\workflows\golangci-lint.yml * change .github\workflows\golangci-lint.yml * fix issues detected by golangci-lint
6b93259
to
3cc7df1
Compare
|
请把 gost 版本升级到最新版 https://github.com/dubbogo/gost/releases/tag/v1.14.1 |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
#2526 add SetLoggerLevel for logger module, logger options can be modified by this function as follow.