[Java] cannot identify different Enum class

[urlyy]

Search before asking

• I had searched in the issues and found no similar issues.

Version

Latest

Component(s)

Java

Minimal reproduce step

enum Color {
  Green,
  Red,
  Blue,
  White,
}

enum Color2 {
    Green,
}

static class EnumWrapper {
  Color color;
}

static class EnumWrapper2 {
    Color2 color;
}

@Test
public void testEnumEnum() {
    Fory fory1 =
            Fory.builder()
                    .withLanguage(Language.XLANG)
                    .withCompatibleMode(CompatibleMode.COMPATIBLE)
                    .withCodegen(false)
                    .build();
    fory1.register(Color.class, 101);
    fory1.register(Color2.class, 102);
    fory1.register(EnumWrapper.class, 103);
    Fory fory2 =
            Fory.builder()
                    .withLanguage(Language.XLANG)
                    .withCompatibleMode(CompatibleMode.COMPATIBLE)
                    .withCodegen(false)
                    .build();
    fory2.register(Color.class, 101);
    fory2.register(Color2.class, 102);
    fory2.register(EnumWrapper2.class, 103);

    EnumWrapper enumWrapper = new EnumWrapper();
    enumWrapper.color = Color.White;
    byte[] serialize = fory1.serialize(enumWrapper);
    EnumWrapper2 wrapper2 = (EnumWrapper2) fory2.deserialize(serialize);
    Assert.assertEquals(Color2.Green, wrapper2.color);
}

What did you expect to see?

pass test

What did you see instead?

org.apache.fory.exception.DeserializationException: Failed to deserialize input

	at org.apache.fory.util.ExceptionUtils.handleReadFailed(ExceptionUtils.java:66)
	at org.apache.fory.Fory.deserialize(Fory.java:889)
	at org.apache.fory.Fory.deserialize(Fory.java:785)
	at org.apache.fory.RustXlangTest.testEnumEnum(RustXlangTest.java:390)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:136)
	at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:658)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:219)
	at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:50)
	at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:923)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethods(TestInvoker.java:192)
	at org.testng.internal.invokers.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
	at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:128)
	at java.util.ArrayList.forEach(ArrayList.java:1259)
	at org.testng.TestRunner.privateRun(TestRunner.java:808)
	at org.testng.TestRunner.run(TestRunner.java:603)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:429)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:423)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:383)
	at org.testng.SuiteRunner.run(SuiteRunner.java:326)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:95)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1249)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1169)
	at org.testng.TestNG.runSuites(TestNG.java:1092)
	at org.testng.TestNG.run(TestNG.java:1060)
	at com.intellij.rt.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:65)
	at com.intellij.rt.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:105)
Caused by: java.lang.IllegalArgumentException: Enum ordinal 3 not in [Green]
	at org.apache.fory.serializer.EnumSerializer.handleNonexistentEnumValue(EnumSerializer.java:122)
	at org.apache.fory.serializer.EnumSerializer.xread(EnumSerializer.java:112)
	at org.apache.fory.serializer.EnumSerializer.xread(EnumSerializer.java:32)
	at org.apache.fory.Fory.xreadNullable(Fory.java:1132)
	at org.apache.fory.serializer.SerializationBinding$XlangSerializationBinding.readNullable(SerializationBinding.java:396)
	at org.apache.fory.serializer.SerializationBinding$XlangSerializationBinding.readNullable(SerializationBinding.java:403)
	at org.apache.fory.serializer.AbstractObjectSerializer.readFinalObjectFieldValue(AbstractObjectSerializer.java:94)
	at org.apache.fory.serializer.MetaSharedSerializer.read(MetaSharedSerializer.java:194)
	at org.apache.fory.serializer.MetaSharedSerializer.xread(MetaSharedSerializer.java:261)
	at org.apache.fory.Fory.xreadNonRef(Fory.java:1121)
	at org.apache.fory.Fory.xreadRef(Fory.java:1056)
	at org.apache.fory.Fory.deserialize(Fory.java:883)
	... 29 more

Anything Else?

It seems that #2719 is wrong.

Are you willing to submit a PR?

• I'm willing to submit a PR!

[bytelazy]

env

java version: 11.0.24
fory version: 0.11.0 or 0.12.3

output

• follow minimal reproduce step, the results:

java.lang.IllegalArgumentException: class demo.EnumReproTest$EnumWrapper is not a struct

	at org.apache.fory.util.Preconditions.checkArgument(Preconditions.java:77)
	at org.apache.fory.meta.TypeDefEncoder.encodeClassDef(TypeDefEncoder.java:96)
	at org.apache.fory.meta.TypeDefEncoder.buildClassDefWithFieldInfos(TypeDefEncoder.java:81)
	at org.apache.fory.meta.TypeDefEncoder.buildTypeDef(TypeDefEncoder.java:65)
	at org.apache.fory.meta.ClassDef.buildClassDef(ClassDef.java:1030)
	at org.apache.fory.meta.ClassDef.buildClassDef(ClassDef.java:1025)
	at org.apache.fory.resolver.ClassResolver.lambda$getClassDef$12(ClassResolver.java:1747)
	at java.base/java.util.HashMap.computeIfAbsent(HashMap.java:1134)
	at org.apache.fory.resolver.ClassResolver.getClassDef(ClassResolver.java:1747)
	at org.apache.fory.serializer.ObjectSerializer.<init>(ObjectSerializer.java:98)
	at org.apache.fory.serializer.ObjectSerializer.<init>(ObjectSerializer.java:82)
	at org.apache.fory.resolver.XtypeResolver.lambda$register$0(XtypeResolver.java:237)
	at org.apache.fory.serializer.LazySerializer.xwrite(LazySerializer.java:61)
	at org.apache.fory.Fory.xwriteData(Fory.java:611)
	at org.apache.fory.Fory.xwriteRef(Fory.java:546)
	at org.apache.fory.Fory.xwrite(Fory.java:419)
	at org.apache.fory.Fory.serialize(Fory.java:327)
	at org.apache.fory.Fory.serialize(Fory.java:279)
	at demo.EnumReproTest.reproduceIssue2720(EnumReproTest.java:51)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)

• change language.xlang to language.java, the results:

java.lang.IllegalArgumentException: Class class java.util.OptionalDouble with id 101 has been registered, registering class demo.EnumReproTest$Color with same id are not allowed.

	at org.apache.fory.resolver.ClassResolver.checkRegistration(ClassResolver.java:537)
	at org.apache.fory.resolver.ClassResolver.register(ClassResolver.java:458)
	at org.apache.fory.Fory.register(Fory.java:180)
	at demo.EnumReproTest.reproduceIssue2720(EnumReproTest.java:35)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)

[chaokunyang]

#2719 is wrong. We still needs to write whole type If instead of just 8 bits. What We should do is create field type based on little 8 bits.

@bytelazy Would you like to work on a fix?

[bytelazy]

#2719 is wrong. We still needs to write whole type If instead of just 8 bits. What We should do is create field type based on little 8 bits.

@bytelazy Would you like to work on a fix?

Hi @chaokunyang ,
Could you please share more details or open a follow-up issue to clarify the expected behavior — particularly how to handle the “whole type” vs “8 bits” case?
That would help evaluate whether i can fix is consistent with your intended design.
Thanks.

[chaokunyang]

Just write whole xtype id, but when decode typeinfo, use little 8 bits to determine which field type it should be.

[bytelazy]

Just write whole xtype id, but when decode typeinfo, use little 8 bits to determine which field type it should be.

I'm exploring this issue for the first time and would like to contribute a fix.
Could you please point me to the part of the code responsible for writing/decoding the xtype id and typeinfo (where the 8-bit field type logic is handled)?
Understanding that section will help ensure my patch follows your intended design.

Thanks for your help!

[chaokunyang]

@bytelazy you can start with reading code in java/fory-core/src/main/java/org/apache/fory/meta/ClassDef.java, java/fory-core/src/main/java/org/apache/fory/meta/TypeDefDecoder.java, and java/fory-core/src/main/java/org/apache/fory/meta/TypeDefEncoder.java.