Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Provide Metrics for Gravitino MySQL Backend Storage Connect Pool #5578

Open
TEOTEO520 opened this issue Nov 14, 2024 · 1 comment
Labels
improvement Improvements on everything

Comments

@TEOTEO520
Copy link
Contributor

What would you like to be improved?

Currently, many parameters of the MySQL backend connection pool used by Gravitino, such as maxConnectCount and maxIdleConnect, are not configurable, and no relevant monitoring is configured for this connection pool. However, in reality, nearly every Gravitino REST request involves a call to the backend storage. Therefore, I believe it is essential to configure connection pool monitoring for a backend storage like MySQL in a production environment.

How should we improve?

We have configured monitoring for the MySQL backend in production. You can assign this to me, and I will complete it.

@TEOTEO520 TEOTEO520 added the improvement Improvements on everything label Nov 14, 2024
@TEOTEO520 TEOTEO520 changed the title [Improvement] Provide Gravitino MySQL Backend Storage Connect Pool [Improvement] Provide Metrics for Gravitino MySQL Backend Storage Connect Pool Nov 14, 2024
@TEOTEO520 TEOTEO520 changed the title [Improvement] Provide Metrics for Gravitino MySQL Backend Storage Connect Pool [Improvement] Provide Metrics for Gravitino MySQL Backend Storage Connect Pool Nov 14, 2024
@xloya
Copy link
Collaborator

xloya commented Nov 14, 2024

It's a useful feature, maybe we can report the connection pool metrics to the prometheus (already used by the API metrics). By the way, from my current feeling, this feature requires multiple PRs to complete, maybe you can list the sub tasks firstly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
Development

No branches or pull requests

2 participants