Skip to content

Commit f10c0ab

Browse files
authored
ci: Don't dismiss stale review to make contribution easier (#1799)
## Which issue does this PR close? - Closes #. ## What changes are included in this PR? I made this change to avoid dismissing stale reviews to make contributions easier. iceberg is quite active, and we nearly have conflicts every day. It can be a pain for contributors to get approved, especially after resolving conflicts—they then have to wait for reviewers to give another approval. I think we can make it clear that trivial changes like resolving merge conflicts are allowed, but adding other code changes aren't. We can just add this to the docs so it’s easier for everyone. ## Are these changes tested?
1 parent 3cb18e7 commit f10c0ab

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.asf.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ github:
4040

4141
required_pull_request_reviews:
4242
required_approving_review_count: 1
43-
dismiss_stale_reviews: true
43+
dismiss_stale_reviews: false
4444

4545
required_linear_history: true
4646
del_branch_on_merge: true

0 commit comments

Comments
 (0)