Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for ColumnarBatchUtil using mocking #12054

Open
3 tasks
aokolnychyi opened this issue Jan 22, 2025 · 2 comments
Open
3 tasks

Add unit tests for ColumnarBatchUtil using mocking #12054

aokolnychyi opened this issue Jan 22, 2025 · 2 comments
Labels
good first issue Good for newcomers improvement PR that improves existing functionality

Comments

@aokolnychyi
Copy link
Contributor

Feature Request / Improvement

We need to add tests for ColumnarBatchUtil using mocking to verify correctness of buildRowIdMapping and buildIsDeleted.

Query engine

Spark

Willingness to contribute

  • I can contribute this improvement/feature independently
  • I would be willing to contribute this improvement/feature with guidance from the Iceberg community
  • I cannot contribute this improvement/feature at this time
@aokolnychyi aokolnychyi added good first issue Good for newcomers improvement PR that improves existing functionality labels Jan 22, 2025
@aokolnychyi
Copy link
Contributor Author

The class was added as part of #11933.

@anuragmantri
Copy link
Contributor

I have some context on this one as I was looking at an issue with caching delete files in the executor. I will add the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement PR that improves existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aokolnychyi @anuragmantri