Skip to content

Commit b8ec5ef

Browse files
committed
IGNITE-26314 Use new ResultSet implementation in JdbcDatabaseMetadata.
1 parent 20d3410 commit b8ec5ef

File tree

6 files changed

+676
-304
lines changed

6 files changed

+676
-304
lines changed

modules/jdbc/src/integrationTest/java/org/apache/ignite/internal/jdbc/ItJdbcMetadataSelfTest.java

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,15 @@
3636
import java.util.List;
3737
import java.util.StringJoiner;
3838
import java.util.UUID;
39-
import org.apache.ignite.internal.jdbc.proto.event.JdbcColumnMeta;
39+
import org.apache.ignite.internal.jdbc2.JdbcResultSetMetadata;
40+
import org.apache.ignite.internal.sql.ColumnMetadataImpl;
41+
import org.apache.ignite.internal.sql.ColumnMetadataImpl.ColumnOriginImpl;
42+
import org.apache.ignite.internal.sql.ResultSetMetadataImpl;
4043
import org.apache.ignite.internal.sql.engine.util.SqlTestUtils;
4144
import org.apache.ignite.internal.type.NativeType;
4245
import org.apache.ignite.jdbc.AbstractJdbcSelfTest;
46+
import org.apache.ignite.sql.ColumnMetadata;
47+
import org.apache.ignite.sql.ColumnMetadata.ColumnOrigin;
4348
import org.apache.ignite.sql.ColumnType;
4449
import org.junit.jupiter.api.BeforeAll;
4550
import org.junit.jupiter.api.Disabled;
@@ -77,24 +82,27 @@ public void testDatabaseMetaDataColumns() throws Exception {
7782
try {
7883
DatabaseMetaData dbMeta = conn.getMetaData();
7984

80-
List<JdbcColumnMeta> columnsMeta = new ArrayList<>();
85+
List<ColumnMetadata> columnsMeta = new ArrayList<>();
8186
try (ResultSet rs = dbMeta.getColumns(null, "META", "TEST", null)) {
8287
while (rs.next()) {
83-
JdbcColumnMeta meta = new JdbcColumnMeta(
84-
rs.getString("COLUMN_NAME"),
88+
ColumnOrigin origin = new ColumnOriginImpl(
8589
rs.getString("TABLE_SCHEM"),
8690
rs.getString("TABLE_NAME"),
91+
rs.getString("COLUMN_NAME")
92+
);
93+
ColumnMetadata meta = new ColumnMetadataImpl(
8794
rs.getString("COLUMN_NAME"),
8895
dataTypeToColumnType(rs.getInt("DATA_TYPE"), rs.getString("TYPE_NAME")),
89-
rs.getShort("COLUMN_SIZE"),
90-
rs.getShort("DECIMAL_DIGITS"),
91-
"YES".equals(rs.getString("IS_NULLABLE"))
96+
rs.getInt("COLUMN_SIZE"),
97+
rs.getInt("DECIMAL_DIGITS"),
98+
"YES".equals(rs.getString("IS_NULLABLE")),
99+
origin
92100
);
93101
columnsMeta.add(meta);
94102
}
95103
}
96104

97-
ResultSetMetaData rsMeta = new JdbcResultSetMetadata(columnsMeta);
105+
ResultSetMetaData rsMeta = new JdbcResultSetMetadata(new ResultSetMetadataImpl(columnsMeta));
98106
checkMeta(rsMeta);
99107
} finally {
100108
stmt.execute("DROP TABLE META.TEST;");
@@ -161,7 +169,6 @@ private ColumnType dataTypeToColumnType(int dataType, String typeName) {
161169
}
162170

163171
@Test
164-
@Disabled("https://issues.apache.org/jira/browse/IGNITE-26145")
165172
public void testResultSetMetaDataColumns() throws Exception {
166173
createMetaTable();
167174

0 commit comments

Comments
 (0)