Fix issue#317 Perfect kvrocks-controller election #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
reviewed
Jun 13, 2025
store/cluster_shard.go
Outdated
| @@ -173,6 +173,11 @@ func (shard *Shard) getNewMasterNodeIndex(ctx context.Context, masterNodeIndex i | |||
| if clusterNodeInfo.Sequence >= newestOffset { | |||
| newMasterNodeIndex = i | |||
| newestOffset = clusterNodeInfo.Sequence | |||
|
|
|||
| // only when the slave nodes's master_link_status is not up can be selected as the new master | |||
| if clusterNodeInfo.MasterLinkStatus != "up" { | |||
There was a problem hiding this comment.
Should move this after line 167, and continue if the master link is broken.
There was a problem hiding this comment.
Thanks hulk advise! I resubmitted the fix code, please check it out
There was a problem hiding this comment.
@hll1213181368 I realized that we cannot simply filter by the master link status, because all replicas would be in down state if the master node is not present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perfect kvrocks-controller election #317