Skip to content

sync cluster info to nodes concurrently #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2025

Conversation

greatsharp
Copy link
Contributor

if a node syncs failed, all nodes behind it won't be synced
to avoid it, sync cluster info to nodes in goroutines

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.99%. Comparing base (6c56470) to head (4599b12).
Report is 69 commits behind head on unstable.

Files with missing lines Patch % Lines
controller/cluster.go 78.57% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #320      +/-   ##
============================================
+ Coverage     43.38%   46.99%   +3.60%     
============================================
  Files            37       45       +8     
  Lines          2971     4403    +1432     
============================================
+ Hits           1289     2069     +780     
- Misses         1544     2127     +583     
- Partials        138      207      +69     
Flag Coverage Δ
unittests 46.99% <80.00%> (+3.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@git-hulk git-hulk merged commit 43b567c into apache:unstable Jun 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants