Skip to content

Validate the preferred node id format in failover API #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Jul 7, 2025

Currently, it will still promote a new master even through the preferred node is in invalid format, and it might cause confusing since the new master is not what users expected.

Currently, it will still promote a new master even through the preferred
node is in invalid format, and it might cause confusing since the new
master is not what users expected.
@git-hulk git-hulk requested review from torwig and PragmaTwice July 7, 2025 12:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.05%. Comparing base (6c56470) to head (fc34404).
Report is 70 commits behind head on unstable.

Files with missing lines Patch % Lines
server/api/shard.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #323      +/-   ##
============================================
+ Coverage     43.38%   47.05%   +3.67%     
============================================
  Files            37       45       +8     
  Lines          2971     4401    +1430     
============================================
+ Hits           1289     2071     +782     
- Misses         1544     2122     +578     
- Partials        138      208      +70     
Flag Coverage Δ
unittests 47.05% <0.00%> (+3.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@git-hulk git-hulk merged commit 4899f99 into apache:unstable Jul 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants