Potential Data Loss in kvrocks2redis Tool During Sync?

[twoholes]

In the parseKVFromLocalStorage function of the kvrocks2redis tool:
cpp
void Sync::parseKVFromLocalStorage() {
...
Status s = parser_->ParseFullDB(); // Step 1
if (!s.IsOK()) {
LOG(ERROR) << "[kvrocks2redis] Failed to parse full db, encounter error: " << s.Msg();
return;
}
auto last_seq = storage_->GetDB()->GetLatestSequenceNumber(); // Step 2
s = updateNextSeq(last_seq + 1);
if (!s.IsOK()) {
LOG(ERROR) << "[kvrocks2redis] Failed to update next sequence: " << s.Msg();
}
}

Data written between Step 1 (ParseFullDB()) and Step 2 (GetLatestSequenceNumber()) might be lost during synchronization. After Step 1 completes parsing the full database, new writes may occur before Step 2 captures the latest sequence number. These intermediate writes would not be included in the sync process, leading to potential data loss.

Is this a known limitation of the current implementation?

[git-hulk]

@twoholes Kvrocks2Redis uses the RocksDB Secondary Instance mechanism to read the data, so it shouldn't have any updated data before we call the TryCatchUpWithPrimary to update.

[twoholes]

Thank you so much for the response.