Replies: 1 comment
-
I think it is OK to replace them to keep a unified code style. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
ref #711 (comment)
ref #703 (comment)
I noticed there are many places in the code base where used the unique_ptr constructor directly instead of using
MakeUnique
andUniqueIterator
. Do we need to replace them all? I wonder if this fix is worth PRs as it is too trivial and doesn't seem to bring performance benefits.Beta Was this translation helpful? Give feedback.
All reactions