-
Notifications
You must be signed in to change notification settings - Fork 543
Open
Labels
enhancementtype enhancementtype enhancement
Description
Search before asking
- I had searched in the issues and found no similar issues.
Motivation
Currently, the hardware is becoming faster and faster. O_DIRECT
is supported by rocksdb [1], and allowed to be enabled by MyRocks and other applications.
Now, for reader, there're two ways to bypass kernel buffer and user buffer:
mmap
, which shares the buffer among kernel and user space- O_DIRECT, forcing aligned read
RocksDB has limited support for mmap
, see [2]. O_DIRECT might enhance performance, but it also has some counter parts, see [3]
[1] https://github.com/facebook/rocksdb/wiki/Direct-IO
[2] https://smalldatum.blogspot.com/2022/05/using-mmap-with-rocksdb.html
[3] facebook/rocksdb#6448
Solution
The code would be easy, perhaps the most important thing is setting up benchmark on different machines
Are you willing to submit a PR?
- I'm willing to submit a PR!
aleksraiden and git-hulk
Metadata
Metadata
Assignees
Labels
enhancementtype enhancementtype enhancement