[NEW] Add ENCODING subcommand aligned Redis

[dsmai]

Search before asking

• I had searched in the issues and found no similar issues.

Motivation

Adding support for the ENCODING subcommand.

As a first-timer, I was browsing through #595 and https://kvrocks.apache.org/docs/supported-commands/#object-subcommands, I see that ENCODING (and 3 other OBJECT subcommands) is not yet supported.

From here, https://redis.io/docs/latest/commands/object-encoding/, I see that this subcommand was available from Redis 2.2.3. I am curious why kvrocks does not support it yet? If possible, could I open a PR to add support for it? @PragmaTwice

Solution

I am not sure yet. I will do some research once this is issue is validated.

Are you willing to submit a PR?

• I'm willing to submit a PR!

[PragmaTwice]

Since Kvrocks is an on-disk database, the encoding is quite different from Redis.

You can check https://kvrocks.apache.org/community/data-structure-on-rocksdb for more details about this.

So I'm not sure if it's good to us to support this command.

[dsmai]

Good to know, thanks. Other than that, do you think if Kvrocks is still missing some other Redis commands?

[PragmaTwice]

Yeah but I don't have a full list of what is missing to give you.

Generally if a command exists in Redis and is able and useful to implement in Kvrocks, it can be a good task.

You can check https://redis.io/docs/latest/commands/ and https://kvrocks.apache.org/docs/supported-commands/ to see if there is something missing.