Skip to content

Commit ceb8453

Browse files
yaooqinnyaooqinn
committed
[KYUUBI #5501] Update codecov token and fix codecov reporting on PRs
### _Why are the changes needed?_ Update codecov token to fix stale code coverage action ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ no Closes #5501 from yaooqinn/token. Closes #5501 1f40532 [Kent Yao] java-17 fcd8391 [Kent Yao] java-17 5ccead7 [Kent Yao] upgrade jacoco 5cb4a83 [Kent Yao] Revert "rm" 45d7a21 [Kent Yao] rm 0a3dd2f [Kent Yao] Update codecov token Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
1 parent fbf3954 commit ceb8453

File tree

4 files changed

+57
-23
lines changed

4 files changed

+57
-23
lines changed

‎.github/workflows/master.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ jobs:
108108
run: |
109109
TEST_MODULES="dev/kyuubi-codecov"
110110
./build/mvn clean install ${MVN_OPT} -pl ${TEST_MODULES} -am \
111-
-Pspark-${{ matrix.spark }} -Pspark-authz-hudi-test ${{ matrix.spark-archive }} ${{ matrix.exclude-tags }}
111+
-Pjava-${{ matrix.java }} -Pspark-${{ matrix.spark }} -Pspark-authz-hudi-test ${{ matrix.spark-archive }} ${{ matrix.exclude-tags }}
112112
- name: Code coverage
113113
if: |
114114
matrix.java == 8 &&

‎codecov.yml

+8-1
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,11 @@
1616
#
1717

1818
codecov:
19-
token: b624e642-b0c8-4d45-94a1-a370888435bb
19+
token: 5115fd3e-2ef2-40ed-b012-376a2afdc382
20+
21+
coverage:
22+
status:
23+
project:
24+
default:
25+
target: auto # auto compares coverage to the previous base commit
26+
threshold: 2% #this allows a 2% drop from the previous base commit coverage

‎dev/kyuubi-codecov/pom.xml

+12
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,18 @@
3131
<url>https://kyuubi.apache.org/</url>
3232

3333
<dependencies>
34+
<dependency>
35+
<groupId>org.apache.kyuubi</groupId>
36+
<artifactId>kyuubi-util</artifactId>
37+
<version>${project.version}</version>
38+
</dependency>
39+
40+
<dependency>
41+
<groupId>org.apache.kyuubi</groupId>
42+
<artifactId>kyuubi-util-scala_${scala.binary.version}</artifactId>
43+
<version>${project.version}</version>
44+
</dependency>
45+
3446
<dependency>
3547
<groupId>org.apache.kyuubi</groupId>
3648
<artifactId>kyuubi-common_${scala.binary.version}</artifactId>

‎pom.xml

+36-21
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,9 @@
243243
<maven.plugin.scalatest.include.tags></maven.plugin.scalatest.include.tags>
244244
<maven.plugin.scalatest.debug.enabled>false</maven.plugin.scalatest.debug.enabled>
245245
<maven.plugin.spotless.version>2.30.0</maven.plugin.spotless.version>
246-
<maven.plugin.jacoco.version>0.8.7</maven.plugin.jacoco.version>
246+
<maven.plugin.surefire.version>3.2.1</maven.plugin.surefire.version>
247+
<maven.plugin.surefire.argLine></maven.plugin.surefire.argLine>
248+
<maven.plugin.jacoco.version>0.8.11</maven.plugin.jacoco.version>
247249
<maven.plugin.scalastyle.version>1.0.0</maven.plugin.scalastyle.version>
248250
<maven.plugin.shade.version>3.4.1</maven.plugin.shade.version>
249251
<maven.plugin.silencer.version>1.7.13</maven.plugin.silencer.version>
@@ -273,24 +275,6 @@
273275
<distMgmtSnapshotsName>Apache Development Snapshot Repository</distMgmtSnapshotsName>
274276
<distMgmtSnapshotsUrl>https://repository.apache.org/content/repositories/snapshots</distMgmtSnapshotsUrl>
275277

276-
<extraJavaTestArgs>-XX:+IgnoreUnrecognizedVMOptions
277-
--add-opens=java.base/java.lang=ALL-UNNAMED
278-
--add-opens=java.base/java.lang.invoke=ALL-UNNAMED
279-
--add-opens=java.base/java.lang.reflect=ALL-UNNAMED
280-
--add-opens=java.base/java.io=ALL-UNNAMED
281-
--add-opens=java.base/java.net=ALL-UNNAMED
282-
--add-opens=java.base/java.nio=ALL-UNNAMED
283-
--add-opens=java.base/java.util=ALL-UNNAMED
284-
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
285-
--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED
286-
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED
287-
--add-opens=java.base/sun.nio.cs=ALL-UNNAMED
288-
--add-opens=java.base/sun.security.action=ALL-UNNAMED
289-
--add-opens=java.base/sun.security.tools.keytool=ALL-UNNAMED
290-
--add-opens=java.base/sun.security.x509=ALL-UNNAMED
291-
--add-opens=java.base/sun.util.calendar=ALL-UNNAMED
292-
-Djdk.reflect.useDirectMethodHandle=false
293-
-Dio.netty.tryReflectionSetAccessible=true</extraJavaTestArgs>
294278
<debugArgLine>-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5005</debugArgLine>
295279
</properties>
296280

@@ -1697,7 +1681,7 @@
16971681
<configuration>
16981682
<skipTests>true</skipTests>
16991683
<failIfNoSpecifiedTests>false</failIfNoSpecifiedTests>
1700-
<argLine>${extraJavaTestArgs}</argLine>
1684+
<argLine>${maven.plugin.surefire.argLine}</argLine>
17011685
</configuration>
17021686
</plugin>
17031687
<!-- enable scalatest -->
@@ -1709,7 +1693,7 @@
17091693
<reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
17101694
<junitxml>.</junitxml>
17111695
<filereports>TestSuite.txt</filereports>
1712-
<argLine>${extraJavaTestArgs}</argLine>
1696+
<argLine>${maven.plugin.surefire.argLine}</argLine>
17131697
<environmentVariables>
17141698
<KYUUBI_WORK_DIR_ROOT>${project.build.directory}/work</KYUUBI_WORK_DIR_ROOT>
17151699
</environmentVariables>
@@ -2135,6 +2119,37 @@
21352119
</properties>
21362120
</profile>
21372121

2122+
<profile>
2123+
<id>java-17</id>
2124+
<activation>
2125+
<jdk>17</jdk>
2126+
</activation>
2127+
<properties>
2128+
<java.version>17</java.version>
2129+
<maven.compiler.source></maven.compiler.source>
2130+
<maven.compiler.target></maven.compiler.target>
2131+
<maven.compiler.release>${java.version}</maven.compiler.release>
2132+
<maven.plugin.surefire.argLine>-XX:+IgnoreUnrecognizedVMOptions
2133+
--add-opens=java.base/java.lang=ALL-UNNAMED
2134+
--add-opens=java.base/java.lang.invoke=ALL-UNNAMED
2135+
--add-opens=java.base/java.lang.reflect=ALL-UNNAMED
2136+
--add-opens=java.base/java.io=ALL-UNNAMED
2137+
--add-opens=java.base/java.net=ALL-UNNAMED
2138+
--add-opens=java.base/java.nio=ALL-UNNAMED
2139+
--add-opens=java.base/java.util=ALL-UNNAMED
2140+
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
2141+
--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED
2142+
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED
2143+
--add-opens=java.base/sun.nio.cs=ALL-UNNAMED
2144+
--add-opens=java.base/sun.security.action=ALL-UNNAMED
2145+
--add-opens=java.base/sun.security.tools.keytool=ALL-UNNAMED
2146+
--add-opens=java.base/sun.security.x509=ALL-UNNAMED
2147+
--add-opens=java.base/sun.util.calendar=ALL-UNNAMED
2148+
-Djdk.reflect.useDirectMethodHandle=false
2149+
-Dio.netty.tryReflectionSetAccessible=true</maven.plugin.surefire.argLine>
2150+
</properties>
2151+
</profile>
2152+
21382153
<!-- For development only, not generally applicable for all modules -->
21392154
<profile>
21402155
<id>scala-2.13</id>

0 commit comments

Comments
 (0)