[MARTIFACT-80] `ignore` doesn't work on the main module artifact

[jira-importer]

Christopher Ng opened MARTIFACT-80 and commented

The ignore configuration option doesn't work on the main artifact of the module, only on additional attached artifacts.

Use case I have is that we're building RPMs on a (very) old CentOS version and they have attributes that aren't easily 'fixable' to be cleanly rebuilt. I ignore 'failures' in those individual modules, but when the plugin tries to do the aggregated buildInfo on the last module those RPMs aren't ignored, and I don't want to ignore failures for every module in the aggregator.

---

Affects: 3.5.3

Remote Links:

• GitHub Pull Request #71
  

[jira-importer]

Hervé Boutemy commented

hi Christopher Ng, thaks for the contribution
I'd like to better understand the use case: can you point me to a sample failing project?
I don't get the problem description (nor in a second stage how code change relates, but that'll be a second step)

[jira-importer]

Hervé Boutemy commented

thinking again...
given ignore permits to define glob patterns based on groupId and filename, I'd expect you can ignore anything

one idea: are you using compare from CLI, including -Dbuildinfo.ignore?
or are you trying to configure something in pom.xml?

notice: I want to do a release soon for MARTIFACT-81, I'll may release without this issue understood, sorry, but I'm very interested into understanding your use case

[jira-importer]

Christopher Ng commented

i've come back to this again, actually it doesn't matter whether you place the config at the top-level of the reactor or in an individual module, you can't ignore the 'main' artifact of a module because it doesn't do the ignore check for those. so in my case we're building an RPM as the main module artifact, and the plugin can't be configured to ignore it.

[hboutemy]

fixed by #182