New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProcessMissedChunks() does not process chunck with IMAGE_UPLOAD_CHUNK_MISSED_WM status #186

Open

ubicore opened this issue Jun 22, 2021 · 0 comments

ubicore commented Jun 22, 2021

If c is == to IMAGE_UPLOAD_CHUNK_MISSED_WM, chunck is never retransmitted ?
https://github.com/apache/mynewt-newtmgr/blob/master/nmxact/xact/image.go#L249
Maybe the test :
if c < IMAGE_UPLOAD_CHUNK_MISSED_WM {
should be :
if c <= IMAGE_UPLOAD_CHUNK_MISSED_WM {
or
if c < 0 {

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment