Skip to content

Commit 5b6a3e3

Browse files
committed
PDFBOX-5660: improve javadoc
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1931441 13f79535-47bb-0310-9956-ffa450edef68
1 parent 1033d94 commit 5b6a3e3

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/filespecification/PDComplexFileSpecification.java

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,14 @@ private COSBase getObjectFromEFDictionary(COSName key)
9090
}
9191

9292
/**
93-
* <p>Preferred method for getting the filename.
94-
* It will determinate the recommended file name.</p>
95-
* <p>First of all we try to get the unicode filename if it exist.
96-
* If it doesn't exist we take a look at the DOS, MAC UNIX filenames.
97-
* If no one exist the required F entry will be returned.</p>
93+
* <p>
94+
* Preferred method for getting the filename. It will determinate the recommended file name.
95+
* <p>
96+
* First of all we try to get the unicode filename if it exists. If it doesn't exist we take a
97+
* look at the DOS, MAC UNIX filenames. If no one exist the required F entry will be returned.
98+
* <p>
99+
* <b>Be aware that the filename may contain a directory separator</b> and needs to be sanitized
100+
* (CWE-22).
98101
*
99102
* @return The preferred file name.
100103
*/
@@ -122,6 +125,8 @@ public String getFilename()
122125

123126
/**
124127
* This will get the unicode file name.
128+
* <b>Be aware that the filename may contain a directory separator</b> and needs to be sanitized
129+
* (CWE-22).
125130
*
126131
* @return The file name.
127132
*/
@@ -144,6 +149,8 @@ public void setFileUnicode( String file )
144149

145150
/**
146151
* This will get the file name.
152+
* <b>Be aware that the filename may contain a directory separator</b> and needs to be sanitized
153+
* (CWE-22).
147154
*
148155
* @return The file name.
149156
*/
@@ -168,6 +175,8 @@ public void setFile( String file )
168175

169176
/**
170177
* This will get the name representing a Dos file.
178+
* <b>Be aware that the filename may contain a directory separator</b> and needs to be sanitized
179+
* (CWE-22).
171180
*
172181
* @return The file name.
173182
*/
@@ -178,6 +187,8 @@ public String getFileDos()
178187

179188
/**
180189
* This will get the name representing a Mac file.
190+
* <b>Be aware that the filename may contain a directory separator</b> and needs to be sanitized
191+
* (CWE-22).
181192
*
182193
* @return The file name.
183194
*/
@@ -188,6 +199,8 @@ public String getFileMac()
188199

189200
/**
190201
* This will get the name representing a Unix file.
202+
* <b>Be aware that the filename may contain a directory separator</b> and needs to be sanitized
203+
* (CWE-22).
191204
*
192205
* @return The file name.
193206
*/

0 commit comments

Comments
 (0)