Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Update partitioned topic subscription assertions in IncrementPartitionsTest #24056

Merged

Conversation

kontotto
Copy link
Contributor

@kontotto kontotto commented Mar 5, 2025

Motivation

The previous assertion only verified subscriptions for partition 15. This change expands the scope to cover all partitions, ensuring comprehensive validation of subscription behavior.

Modifications

Fix assertion to iterate through all partitions and verify subscriptions, ensuring comprehensive coverage instead of checking only partition 15.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: kontotto#5

Copy link
Contributor

@hrsakai hrsakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.26%. Comparing base (bbc6224) to head (73ef211).
Report is 955 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24056      +/-   ##
============================================
+ Coverage     73.57%   74.26%   +0.68%     
+ Complexity    32624     2379   -30245     
============================================
  Files          1877     1861      -16     
  Lines        139502   144209    +4707     
  Branches      15299    16433    +1134     
============================================
+ Hits         102638   107090    +4452     
+ Misses        28908    28693     -215     
- Partials       7956     8426     +470     
Flag Coverage Δ
inttests 26.67% <ø> (+2.08%) ⬆️
systests 23.11% <ø> (-1.22%) ⬇️
unittests 73.77% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1056 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hrsakai hrsakai merged commit 114aaf0 into apache:master Mar 12, 2025
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants