Change apm-spring-cloud-gateway plugin witness class. #11332
weixiang1862
started this conversation in
General
Replies: 2 comments 1 reply
-
You could add new witness classes if you want. It is improving for sure. |
Beta Was this translation helpful? Give feedback.
1 reply
-
fix by apache/skywalking-java#610. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
My spring cloud gateway version is 2.2.5.RELEASE, and I active both optional apm-spring-cloud-gateway 2.0.x, 2.1.x and 3.x plugins, then I found this error, seems 2.1.x plugin and 3.x plugin all actived because 3.x and 2.1.x use the same witness class
org.springframework.cloud.gateway.config.GatewayEnvironmentPostProcessor
.I konw it is stupid to active both 2.0.x, 2.1.x and 3.x optional plugins, but if we change 3.x plugin witness class to
org.springframework.cloud.gateway.config.GatewayLoadBalancerProperties
, and add another witness classorg.springframework.cloud.gateway.filter.LoadBalancerClientFilter
to 2.1.x plugin, we can prevent this error even they all actived.The
org.springframework.cloud.gateway.filter.LoadBalancerClientFilter
exist in 2.1.x and 2.2.x.The
org.springframework.cloud.gateway.config.GatewayLoadBalancerProperties
exist in both 3.x and latest 4.x, I think it is a good choice before 4.x plugin born.Beta Was this translation helpful? Give feedback.
All reactions