Formatting license headers for Apache SkyWalking Eyes

[tisonkun]

When I'm trying to hack skywalking-eyes, annoying (maybe personal bias) warnings about license headers' format and unaligned content always stop the interests to dig more.

For example,

I'd prefer to reformat the content as:

I'm unsure whether such feeling is common or such changes are welcomed in skywalking community and also it's more like an enhancement than new feature or bug fix so that I cannot find a right issue kind to file one. And thus I post this topic here.

If it's welcome to make such changes, I'm glad to submit a PR.

cc @kezhenxu94 what do you think?

[kezhenxu94]

You’re more than welcome to fix this. I’d consider this a bug because it breaks some linting rules, check this issue #8529

because I’ve been using this tool to add license headers to this repo so this is the same issue with #8529

[tisonkun]

Another quick question is whether an "enhancement" issue type desirable? I've introduced it for engula/engula project for those neither a bug or new feature. But code refactor, performance improvement, etc.

[kezhenxu94]

Another quick question is whether an "enhancement" issue type desirable? I've introduced it for engula/engula project for those neither a bug or new feature. But code refactor, performance improvement, etc.

I remember you asked this #7978 (comment)

But I personally think it's OK to add enhancement issue type for those code refactor, performance improvement, error logs improvement. Currently, because these types of works are basically done via the PMC/committer team and we don't create issues to track.

WDYT @wu-sheng ? Asking as you replied in #7978 (comment)

[tisonkun]

Sorry I forget that I've asked previously :/

[tisonkun]

Then I'm OK to adopt SkyWalking's convention to file an issue if any later.

[wu-sheng]

Once you are going to own this issue, and in this case, Zhenxu agreed this is on the right direction, I am fine.
I will just track the status from time to time, in case no activity anymore.