Skip to content

[#2560] improvement(client): Fast fail on hadoop reader initialization failure #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025

Conversation

zuston
Copy link
Member

@zuston zuston commented Jul 22, 2025

What changes were proposed in this pull request?

Fast fail on hadoop reader initialization failure

Why are the changes needed?

When the hadoop reader initialization failed, this exception will be ignored. When the final unexcepted blockIds throws, it’s hard to find out the root cause.

And so, we should fast fail in this case.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing unit tests.

Copy link

github-actions bot commented Jul 22, 2025

Test Results

 3 082 files  ± 0   3 082 suites  ±0   6h 49m 7s ⏱️ +4s
 1 192 tests + 1   1 191 ✅ + 2   1 💤 ±0  0 ❌  - 1 
15 115 runs  +15  15 100 ✅ +16  15 💤 ±0  0 ❌  - 1 

Results for commit 63ac3ff. ± Comparison against base commit f1323ab.

♻️ This comment has been updated with latest results.

jerqi
jerqi previously approved these changes Jul 23, 2025
@zuston zuston changed the title improvement(client): Fast fail on hadoop reader initialization failure [#2560] improvement(client): Fast fail on hadoop reader initialization failure Jul 28, 2025
@zuston zuston linked an issue Jul 28, 2025 that may be closed by this pull request
3 tasks
@zuston zuston merged commit be3a1ff into apache:master Jul 29, 2025
41 checks passed
@zuston zuston deleted the fastFail2 branch July 29, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Fast fail on hadoop reader initialization failure
2 participants