Skip to content

[#2558] improvement(server): Limit the max flush event count for a single buffer #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025

Conversation

xianjingfeng
Copy link
Member

What changes were proposed in this pull request?

Limit the max flush event count for a single buffer.

Why are the changes needed?

Fix: #2558

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Verify in production environment.

Copy link

github-actions bot commented Jul 29, 2025

Test Results

 3 082 files  ±0   3 082 suites  ±0   6h 48m 9s ⏱️ - 1m 48s
 1 193 tests ±0   1 192 ✅ ±0   1 💤 ±0  0 ❌ ±0 
15 123 runs  ±0  15 108 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit 5d36f38. ± Comparison against base commit 1713c1f.

♻️ This comment has been updated with latest results.

@xianjingfeng xianjingfeng requested review from jerqi and zuston July 29, 2025 06:13
@jerqi
Copy link
Contributor

jerqi commented Jul 29, 2025

@zuston Could you help me review this PR? I thought this is used for huge partition, too.

Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The single-buffer triggered event will be added to the flushing queue. To improve the maximum flushing throughput, would it be possible to assign different priorities to these events? @xianjingfeng

@xianjingfeng
Copy link
Member Author

The single-buffer triggered event will be added to the flushing queue. To improve the maximum flushing throughput, would it be possible to assign different priorities to these events? @xianjingfeng

@zuston I think this is not very useful, because even if the event is put into the flush queue, if the flush speed of a single buffer can't keep up, the memory can't be released. The difference is whether to keep the blocks in the memory into blocksMap or inFlushBlockMap.

@zuston
Copy link
Member

zuston commented Jul 31, 2025

Got it. LGTM.

@xianjingfeng xianjingfeng merged commit 41d0fc5 into apache:master Aug 4, 2025
41 checks passed
@xianjingfeng xianjingfeng deleted the issue_2558 branch August 4, 2025 03:21
@xianjingfeng
Copy link
Member Author

@zuston Thanks for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Limit the max flush event count for a single buffer
3 participants