Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventManager is missing from the docs #211

Open
TC-MO opened this issue Jun 10, 2024 · 3 comments
Open

EventManager is missing from the docs #211

TC-MO opened this issue Jun 10, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@TC-MO
Copy link
Contributor

TC-MO commented Jun 10, 2024

While reworking links within platform documentation, I noticed that in Python SDK reference documentation EventManager is completely missing. It seems that it has @ignoredocs https://github.com/apify/apify-sdk-python/blob/master/src/apify/event_manager.py
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. documentation Improvements or additions to documentation. labels Jun 10, 2024
@janbuchar
Copy link
Contributor

Is this a bad thing though? The EventManager is supposed to be hidden under Actor.on and Actor.off.

@vdusek
Copy link
Contributor

vdusek commented Jun 13, 2024

Currently, it's visible in the JS SDK and hidden in the Python SDK. Let's make it consistent (one way or another).

@janbuchar
Copy link
Contributor

I'm in favor of hiding it from the JS SDK docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@janbuchar @vdusek @TC-MO