Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adopting FastMCP #9

Open
punkpeye opened this issue Dec 27, 2024 · 1 comment
Open

Consider adopting FastMCP #9

punkpeye opened this issue Dec 27, 2024 · 1 comment
Assignees

Comments

@punkpeye
Copy link
Contributor

The main benefit of FastMCP is that it cuts down on the boilerplate code for setting up tools, prompts, resources, error handling, etc.

Here is an example PR showing how much code is reduced by adopting FastMCP: https://github.com/pskill9/website-downloader/pull/2/files

All the code maps directly to your existing implementation. The only consideration is that FastMCP uses Zod instead of JSON schema.

Additionally, FastMCP enables SSE transports, which is great to future proof your MCP server.

If you are open to it, I would be happy to raise a PR that does the migration.

@jirispilka
Copy link
Collaborator

I'm sorry for the delayed response.

Thank you for your interest in this MCP; I appreciate it.
This MCP was the initial solution.

I have since moved certain parts of the code to the [RAG Web Browser Actor](apify/rag-web-browser#40) so that the server can run in the cloud. In that implementation, I'm using JSON schema.

Additionally, I'm in the process of creating an [MCP server for all Apify's Actors](https://github.com/apify/actor-mcp-server/tree/feat/implementation) (work in progress). I'm also using JSON schema there.

I might eventually update this MCP in a similar way, but I'm not certain yet.
I really appreciate your offer, but I don't think it's worth investing time into refactoring it at this point.

Thank you again for reaching out.

@jirispilka jirispilka self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants