Skip to content

Use ws instead of faye-websocket for websocket tests #621

@bliuchak

Description

@bliuchak

Currently we have both libraries in our devDependencies. Let's migrate out tests to use ws fully instead of faye-websocket.

Why it makes sense:

  • ws is de-facto a standard websocket library for Node
  • ws has better maintainability (faye-websocket got last commit 2 years ago)
  • ws has better wss support, because of it it's already imported in test/tls_overhead_stats.js
  • no new need to introduce new dependency

Metadata

Metadata

Assignees

No one assigned

    Labels

    debtCode quality improvement or decrease of technical debt.low priorityLow priority issues to be done eventually.t-core-servicesIssues with this label are in the ownership of the core services team.t-unblockingIssues with this label are in the ownership of the unblocking team.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions