Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pending requests from Playwright request queue after timeout #31

Open
jirispilka opened this issue Nov 13, 2024 · 3 comments
Open
Assignees
Labels

Comments

@jirispilka
Copy link
Collaborator

jirispilka commented Nov 13, 2024

Standby mode: request timeout - remove pending requests from Playwright request queue

@jirispilka jirispilka self-assigned this Nov 13, 2024
@jirispilka jirispilka changed the title Standby mode: request timeout - remove pending requests from Playwright request queue Remove pending requests from Playwright request queue after timeout Nov 13, 2024
@jirispilka
Copy link
Collaborator Author

jirispilka commented Nov 13, 2024

It seems I’ll need to switch from MemoryStorage to RequestQueue:

export declare class RequestQueue extends RequestProvider {

Additionally, in standby mode, new requests shouldn’t be added to the forefront, as this might block earlier requests.

@MQ37
Copy link

MQ37 commented Mar 24, 2025

@jirispilka is this issue still relevant? I tested with requestTimeoutSecs=1 in standby and the request queue is empty. Only behaviour I noticed is it returns {"errorMessage":"Timed out"} but after a while the results are still added to the output dataset.

@jirispilka
Copy link
Collaborator Author

Yes, it's relevant—the response is sent without any results, but the crawler continues running for no reason. The user receives an empty response and likely won’t check the dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants