Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal API Key JWT generation not considering API Key expiration #233

Open
theganyo opened this issue Nov 3, 2021 · 0 comments
Open
Labels
bug Something isn't working

Comments

@theganyo
Copy link
Member

theganyo commented Nov 3, 2021

When generating a JWT for Envoy Adapter's API Key verification, the remote-proxy uses a hard-coded duration - which is then read and used by Envoy Adapter for setting the expiry of the API Key validation in the cache. However, the API Key may actually be set to expire sooner than that on Apigee. The exp value on the JWT should take the API Key Expiry into account and use the minimum of the duration to its Expiry and the standard cache duration.

Note: By default, API Key verification is only cached for 15 minutes, so the risk of this being a production issue is likely very minimal.

@theganyo theganyo added the bug Something isn't working label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant