Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriding a header from the target response is needlessly hard #156

Open
fpavageau opened this issue Apr 1, 2020 · 0 comments
Open

Overriding a header from the target response is needlessly hard #156

fpavageau opened this issue Apr 1, 2020 · 0 comments

Comments

@fpavageau
Copy link

Currently, overriding a header from the target response in the source
response requires doing it in both ondata_response (when receiving the first
chunk of data) and in onend_response (for when the response doesn't contain
any data), after verifying that res.headersSent is false. That's clumsy at
best.

I've proposed a fix in #129 a long time ago, but never got any feedback.
@fpavageau fpavageau changed the title Overriding a header is needlessly hard Overriding a header from the target response is needlessly hard Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fpavageau