Skip to content

Possible bug in segment_methods concern #1

@cbarrese

Description

@cbarrese

First I want to thank you for taking the time to release this publicly. I have been using it to create test NCPDP D.0 messages.

I believe the code at the following line will always fail since the initializer of DZero::Transmissions::Groups::TransactionGroup does not expect a hash, but instead keyword args.

https://github.com/apiv/dzero/blob/master/lib/dzero/transmissions/concerns/segments_methods.rb#L61

If I change that line to the following it no longer fails

transaction_groups << ::DZero::Transmissions::Groups::TransactionGroup.new(segments: [])

To reproduce, I believe all you need to do is include any segment that is not Patient or Insurance in the transmission request segments(Pricing for example).

A similar error is in the README request construction example. The request initializer is expecting keyword args and not a hash.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions