Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback not working #26

Open
street-magic opened this issue Jun 23, 2023 · 2 comments
Open

Playback not working #26

street-magic opened this issue Jun 23, 2023 · 2 comments

Comments

@street-magic
Copy link

Any resolution for the playback of saved sonar data?
I have recorded 8-bit sonar data with liboculus and need to parse it. The version of liboculus from 3 years ago does not read correct data, any suggestions?
What is the problem with the playback, maybe I can help.

@amarburg
Copy link
Collaborator

Thanks for the email. Our day-to-day use has transitioned to our ROS-based wrapper, so the non-ROS user tools have atrophied a bit. Let me look at the code and refresh my memory on the issue...

@amarburg
Copy link
Collaborator

To follow up, I took a first crack at re-implementing this feature in the feature/fix_playback branch. Besides bugs introduced by underlying API changes, the major change was the underlying library changed to a callback-based API to userspace.

Unfortunately, the only sample data I have are the short snippets in the test/data/ directory, the flags in this data indicate that gains have been appended to the data, but there aren't enough bytes in the packet for this to be true, leading to a segfault. This might have to do with the age of the snippets ... may have been taken with firmware that predates the "sendGain" feature.

Medium term I should add a sanity check on packet size vs expected contents to avoid the segfault. Short term, please try the new version of oc_client and see if it parses your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants