Refactor multipart parsing errors

Author: calvincestari

Diff for: Tests/ApolloTests/Interceptors/MultipartResponseParsingInterceptorTests.swift

@@ -45,15 +45,15 @@ final class MultipartResponseParsingInterceptorTests: XCTestCase {
 
       expect(result).to(beFailure { error in
         expect(error).to(
-          matchError(MultipartResponseParsingInterceptor.ParsingError.cannotParseResponse)
+          matchError(MultipartResponseParsingInterceptor.ParsingError.missingMultipartBoundary)
         )
       })
     }
 
     wait(for: [expectation], timeout: defaultTimeout)
   }
 
-  func test__error__givenResponse_withMissingMultipartProtocolHeader_shouldReturnError() throws {
+  func test__error__givenResponse_withMissingMultipartProtocolSpecifier_shouldReturnError() throws {
     let subject = InterceptorTester(interceptor: MultipartResponseParsingInterceptor())
 
     let expectation = expectation(description: "Received callback")
@@ -68,15 +68,15 @@ final class MultipartResponseParsingInterceptorTests: XCTestCase {
 
       expect(result).to(beFailure { error in
         expect(error).to(
-          matchError(MultipartResponseParsingInterceptor.ParsingError.cannotParseResponse)
+          matchError(MultipartResponseParsingInterceptor.ParsingError.invalidMultipartProtocol)
         )
       })
     }
 
     wait(for: [expectation], timeout: defaultTimeout)
   }
 
-  func test__error__givenResponse_withUnknownMultipartParser_shouldReturnError() throws {
+  func test__error__givenResponse_withUnknownMultipartProtocolSpecifier_shouldReturnError() throws {
     let subject = InterceptorTester(interceptor: MultipartResponseParsingInterceptor())
 
     let expectation = expectation(description: "Received callback")
@@ -91,7 +91,7 @@ final class MultipartResponseParsingInterceptorTests: XCTestCase {
 
       expect(result).to(beFailure { error in
         expect(error).to(
-          matchError(MultipartResponseParsingInterceptor.ParsingError.cannotParseResponse)
+          matchError(MultipartResponseParsingInterceptor.ParsingError.invalidMultipartProtocol)
         )
       })
     }

Diff for: apollo-ios/Sources/Apollo/MultipartResponseParsingInterceptor.swift

@@ -8,8 +8,11 @@ public struct MultipartResponseParsingInterceptor: ApolloInterceptor {
 
   public enum ParsingError: Error, LocalizedError, Equatable {
     case noResponseToParse
+    @available(*, deprecated, message: "Use the more specific `missingMultipartBoundary` and `invalidMultipartProtocol` errors instead.")
     case cannotParseResponse
     case cannotParseResponseData
+    case missingMultipartBoundary
+    case invalidMultipartProtocol
 
     public var errorDescription: String? {
       switch self {
@@ -19,6 +22,10 @@ public struct MultipartResponseParsingInterceptor: ApolloInterceptor {
         return "The response data could not be parsed."
       case .cannotParseResponseData:
         return "The response data could not be parsed."
+      case .missingMultipartBoundary:
+        return "Missing multipart boundary in the response 'content-type' header."
+      case .invalidMultipartProtocol:
+        return "Missing, or unknown, multipart specification protocol in the response 'content-type' header."
       }
     }
   }
@@ -61,13 +68,22 @@ public struct MultipartResponseParsingInterceptor: ApolloInterceptor {
 
     let multipartComponents = response.httpResponse.multipartHeaderComponents
 
+    guard let boundary = multipartComponents.boundary else {
+      chain.handleErrorAsync(
+        ParsingError.missingMultipartBoundary,
+        request: request,
+        response: response,
+        completion: completion
+      )
+      return
+    }
+
     guard
-      let boundary = multipartComponents.boundary,
       let `protocol` = multipartComponents.protocol,
       let parser = Self.responseParsers[`protocol`]
     else {
       chain.handleErrorAsync(
-        ParsingError.cannotParseResponse,
+        ParsingError.invalidMultipartProtocol,
         request: request,
         response: response,
         completion: completion