FileFinder appears to be in ApolloCodegenLib but it is not.

[jonathan-guide]

I recently updated from 1.4.0 to the latest version, only to find that my swift script suddenly failed to build. The error is "Cannot find 'FileFinder' in scope".

It would appear from the online documentation that I should be able to access FileFinder from ApolloCodegenLib, but looking into the source, it appears to be in the apollo-ios-dev repo. So in order to make my code run I have to add SwiftScriptHelpers as a dependency or copy and paste the FileFinder file to my code.

This is easy enough to do, but the removal of FileFinder from the ApolloCodegenLib isn't referenced anywhere in the change log or other documentation, so it took my a decent amount of time to discover this. Anyone else upgrading from an older version might run into this too, especially since FileFinder is referenced in the now archived iOS Codegen Template

What would be the suggested approach? Any of my suggestions, or something different? Thanks.

[BobaFetters]

Version 1.6.0 was a significant restructure of our repos/packages, codegen is now its own separate SPM package that you will need to include. The migration guide can be found here. The apollo-ios-dev repo contains all of our packages in a development environment.

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.

[jonathan-guide]

@BobaFetters I have followed the migration guide and it does not provide a solution for the issue I experienced.

I have added both the apollo-ios-codegen and apollo-ios packages and the error persists. I'm not sure if FileFinder should be in apollo-ios-codegen, but it's not currently, and it used to be a part of a package.

[BobaFetters]

Ah yea I see where FileFinder was in the new apollo-ios-codegen in the 1.6.0 release, looks like at some point it got removed from there, trying to pinpoint where that happened and why.

[calvincestari]

Hi @jonathan-guide - I've tracked down where it was moved to here, in PR #57. That PR doesn't specifically mention FileFinder but I can speculate that we moved it thinking that it is internal helper code and should not be publicly exposed.

I realize this is breaking and it's unfortunate that access has been removed but there is no custom, nor complicated, logic being done in the findParentFolder function. As a workaround, you should be able to replace that call with URL(fileURLWithPath: #filePath).deletingLastPathComponent() to get the same behaviour.

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.