Multiple deprecation warning directives not compiling

[guilherme-anchorage]

Summary

We have encountered an issue with the code generation process that results in non-compilable code. When we have a field with multiple deprecation warnings, we have the same amount of #warning directives separated with a ,\n which does not compile with the following error - Extra tokens following #warning directive.

Version

1.21.0

Steps to reproduce the behavior

To achieve this we had a query with multiple arguments, where 2 or more are deprecated.

Example:
This GraphQL schema definition

someQuery(
  argumentA: String @deprecated(reason: "Some reason")
  argumentB: String @deprecated(reason: "Some other reason")
): Object!

with the following GraphQL contract

query QueryA{ 
  someQuery(
    argumentA: "",
    argumentB: ""
  )
}

results in the following Swift code generation

public class QueryA: GraphQLQuery {
(...)
    #warning("Argument 'argumentA' of field 'someQuery' is deprecated. Reason: 'Some reason'"),  // Compilation error here
    #warning("Argument 'argumentB' of field 'someQuery' is deprecated. Reason: 'Some other reason'")
    public static var __selections: [ApolloAPI.Selection] { [
      .field("someQuery", Object.self, arguments: [
        "argumentA": "",
        "argumentB": ""
      ]),
    ] }
}

Logs

Anything else?

No response

[calvincestari]

Thanks for raising the issue @guilherme-anchorage. I agree this won't build but oddly enough we have tests that ensure this behaviour - here and here.

I'll get that fixed and out with the next release.

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.

[calvincestari]

@guilherme-anchorage - this is fixed and will be included with the next release.

[guilherme-anchorage]

Thanks for the quick resolution!

[seanperez29]

It's odd, I've updated to version 1.23.0 but I'm still seeing this issue and I'm unable to build my project and put out new releases

[seanperez29]

I think I've discovered some more context, this is a mutation that I already had in my codebase prior to the arguments being marked deprecated. Once they were marked deprecated then I was unable to clear this error, even after removing those arguments and fields from my schema. I then removed this mutation from my schema entirely and tested a different mutation that wasn't in my schema beforehand and that I have never used before, but it matches this scenario exactly with the two deprecated arguments, and my code ended up building successfully.

[calvincestari]

Once they were marked deprecated then I was unable to clear this error, even after removing those arguments and fields from my schema.

Do you mean that code generation was still generating the warning annotations with the erroneous ,? Simply updating to 1.23.0 alone won't resolve the build errors, the operations must be re-generated.