SQLiteError doesn't expose underlying SQLite error code

[calvincestari]

Copied across from https://community.apollographql.com/t/ioss-sqliteerror-doesnt-expose-underlying-sqlite-error-code/9440.

In Pre 1.0 Apollo the calls like:

do {
   return try SQLiteNormalizedCache(fileURL: fileURL)
} catch let sqlError as SQLite.Result {
   ... error handling
}

would throw the SQLite native SQLite.Result error. This allowed client code to precisely catch errors like SQLITE_CORRUPT, SQLITE_NOTADB, SQLITE_BUSY, etc.

In 1.0+ of the Apollo library the underlying SQLite error codes are no longer available. Instead there’s a less expressive enum based Error:

public enum SQLiteError: Error, CustomStringConvertible {
  case execution(message: String)
  case open(path: String)
  case prepare(message: String)
  case step(message: String)
}

Am I missing something? Could the error code be added as another associated value?

[calvincestari]

In Pre 1.0 Apollo the calls like:

I believe this was changed in 1.21.0 with PR #635 when SQLite.swift was removed.

[BobaFetters]

This is fixed with apollographql/apollo-ios-dev#755 and will go out with our next release, it will result in a minor breaking change due to changing the signature of the enum cases for SQLiteError

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.

[potrebic]

Thanks for the awesome turn around time! Kudos.

[potrebic]

I might have embedded the error code in the final "description" string.
And that change is otherwise exactly what I needed.