JSONResponseParsingInterceptor Slow down

[trevholliday]

Summary

We recently upgraded 1.15.1 -> 1.23.0. We are seeing a large slowdown in performance in parsing of larger objects that have deeply nested fragments.

Here is an example of the same query being fetched in the 2 different versions.

1.15.1

☀️ [Graph Query][Deserialization] <REDACT>: {
  "time_ms" : 84.998965263366699
}

1.23.0

☀️ [Graph Query][Deserialization] <REDACT>: {
  "time_ms" : 510.68496704101562
}

Version

1.15.1

Steps to reproduce the behavior

• using apollo 1.23.0 fetch an operation that has a large response with multiple deeply nested fragments. In comparison to 1.15.1 notice a substantial slow down in the response parsing.

Logs

Anything else?

No response

[calvincestari]

@trevholliday, is this a consistent drop in performance? If you take an average across 1000 iterations (would need a test case for this) does parse time remain elevated?

[trevholliday]

@calvincestari i will get you a number on Monday for the average of 100 iterations

[trevholliday]

@calvincestari here is a log of 100 deserialization times.

We had an average of 500.82 ms.

deserialization_times.txt

[calvincestari]

@trevholliday, can you put together a sample project that demonstrates this please. Initializing a model with similarly nested response data should exhibit the same and give us a base to debug from. It'll need to run through the networking to follow the same full path of GraphQL execution.

Can you determine through Instruments where the additional time is being used?

[trevholliday]

Hi Calvin, I am going to be traveling for the next few weeks and be unable to get additional insight via instruments. When i get back into office I can investigate further on our side.