add support for ESM (#4590)

* add support for ESM

* switch promise timeout for nexttick

* focus considerations for media uploader

* remove logs

* restore focus to last selected item after prop change

* add import fresh

* use frontend as esm in test

* add missing await on moog define

* add buildRoot method and test both root in cjs and esm mode

* type module is required to be able to start esm mode

* remove unused variables

* expose buildRoot & getNpmPath methods
test esm project

* test esm using npm test

* "fix" aws4 missing dependency

* make sure we have modal

* split button focus, widget priority button

* use async import

* fix sass warnings

* async getSessionOptions

* add fallback to require

* update workflow dependencies

* update dev dependencies

* remove object.values around bundle

* remove conditional rendering

* flex media manager containers

* Fix media manager not handling search results properly (sometimes)

* async getSessionOptions and failsafe getNpmPath

* fix lint issues

* match when using coverage from nyc

* sequential getMeta

* allow build with esm support

* clean changelog

* remove unrelated change data

* remove EOL mongo versions

* remove package type

* remove comment

* getLocales and verifyLocales are now longer async

* avoid adding .js at the end to support npm packages

---------

Co-authored-by: Harouna Traoré <[email protected]>
Co-authored-by: Stuart Romanek <[email protected]>
Co-authored-by: Miro Yovchev <[email protected]>

Author: 3 people

.github/workflows/main.yml

@@ -18,21 +18,21 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [18, 20]
-        mongodb-version: [4.4, 5.0, 6.0, 7.0]
+        node-version: [18, 20, 22]
+        mongodb-version: [6.0, 7.0, 8.0]
 
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
       - name: Git checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
 
       - name: Start MongoDB
-        uses: supercharge/mongodb-github-action@1.3.0
+        uses: supercharge/mongodb-github-action@1.11.0
         with:
           mongodb-version: ${{ matrix.mongodb-version }}
 

.gitignore

@@ -3,9 +3,6 @@
 # Ignore unison sync files
 .unison*
 package-lock.json
-test/public/modules/*
-test/public/css/master-*
-test/locales
 npm-debug.log
 *.DS_Store
 *.npmignore
@@ -14,12 +11,6 @@ npm-debug.log
 .out
 coverage
 /node_modules
-/test/node_modules
-/test/workspaces-project/node_modules
-test/package.json
-test/public
-test/apos-build
-test/workspaces-project/node_modules
 
 # We do not commit CSS, only LESS, with the exception of a few vendor CSS files we don't have LESS for
 */public/css/*.css
@@ -29,6 +20,18 @@ modules/*/public/css/*.css
 # Never commit a CSS map file, anywhere
 *.css.map
 
+test/public/modules/*
+test/public/css/master-*
+test/locales
+/test/node_modules
+/test/workspaces-project/node_modules
+/test/esm-project/node_modules
+test/package.json
+test/public
+test/apos-build
+test/workspaces-project/node_modules
+test/esm-project/node_modules
+
 # Dont commit test generated css
 test/public/css/*.css
 test/public/css/master-*.less

CHANGELOG.md

@@ -7,6 +7,7 @@
 * Elements inside modals can have a `data-apos-focus-priority` attribute that prioritizes them inside the focusable elements list.
 * Modals will continute trying to find focusable elements until an element marked `data-apos-focus-priority` appears or the max retry threshold is reached.
 * Takes care of an edge case where Media Manager would duplicate search results.
+* Add support for ESM projects.
 * Modules can now have a `before: "module-name"` property in their configuration to initialize them before another module, bypassing the normal
 order implied by `defaults.js` and `app.js`.
 * `select` and `checkboxes` fields that implement dynamic choices can now take into account the value of other fields on the fly, by specifying
@@ -23,6 +24,8 @@ with dynamic choices in this way.
 ### Changes
 
 * Silence deprecation warnings from Sass 1.80+ regarding the use of `@import`. The Sass team [has stated there will be a two-year transition period](https://sass-lang.com/documentation/breaking-changes/import/#transition-period) before the feature is actually removed. The use of `@import` is common practice in the Apostrophe codebase and in many project codebases. We will arrange for an orderly migration to the new `@use` directive before Sass 3.x appears.
+* Internal methods `mergeConfiguration`, `autodetectBundles`, `lintModules`, `nestedModuleSubdirs` and `testDir` are now async.
+* `express.getSessionOptions` is now async.
 
 ### Fixes