Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sending to multiple different certs #365

Open
gardenia opened this issue Aug 22, 2018 · 5 comments
Open

support sending to multiple different certs #365

gardenia opened this issue Aug 22, 2018 · 5 comments
Assignees
Labels

Comments

@gardenia
Copy link

Hi,

At the moment it appears I can configure exactly one Android API key and one IOS push certificate.

I would like the capability to somehow disptach to different Android API keys and IOS push certificates, perhaps based on an app bundle id. I realize I could run N instances of gorush to accomplish that but it seems more ideal to be be able to do it all from the same process.

What do you think?

e.g.

android:
  com.foo.bar:
    enabled: true
    apikey: "YOUR_API_KEY1"
    max_retry: 0 # resend fail notification, default value zero is disabled
  com.blah.blah:
    enabled: true
    apikey: "YOUR_API_KEY2"
    max_retry: 0 # resend fail notification, default value zero is disabled
@appleboy
Copy link
Owner

Gorush doesn't support multiple certificates in iOS but support send notification in the different android key.

In android, you can add api_key in the request body. See https://github.com/appleboy/gorush#request-body

@wahello
Copy link

wahello commented May 1, 2019

@appleboy @gardenia APNS is using Universal Push Notification Client SSL, so just one cert is ok. This issue can be closed.

@appleboy
Copy link
Owner

appleboy commented May 1, 2019

@keyeMyria Thanks

@appleboy appleboy closed this as completed May 1, 2019
@gardenia
Copy link
Author

gardenia commented May 1, 2019

I don't believe this is related to my original question. I wanted the ability to use a single gorunsh instance to send pushes to:

some.bundle.id -> cert1.pem
other.bundle.id -> cert2.pem

by dispatching to the different certs on the bundle id. I don't see what "Universal Push Notification Client SSL" has to do with this as it appears to related to production vs development pushes for the same bundle id using one cert.

It may be that gorush never plans to support this. and if so fair enough. I just don't see how Universal Push Notification Client SSL solves it.

@marius-bardan
Copy link

might be addressed via #564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants