From d4790367016325253fdc3600b71362ba8769e9ab Mon Sep 17 00:00:00 2001 From: "Michael R. Wolf" Date: Sun, 3 Nov 2024 19:08:09 -0500 Subject: [PATCH 1/2] . t New test: 'test_issue_179' + TODO_issue_179.md Co-Authored-By: Jay Bazuzi Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com> Co-Authored-By: Susan Fung <38925660+susanfung@users.noreply.github.com> --- TODO_issue_179.md | 41 +++++++++++++++++++++++++++++++++++++++++ test_issue_179 | 41 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 82 insertions(+) create mode 100644 TODO_issue_179.md create mode 100644 test_issue_179 diff --git a/TODO_issue_179.md b/TODO_issue_179.md new file mode 100644 index 0000000..6925c34 --- /dev/null +++ b/TODO_issue_179.md @@ -0,0 +1,41 @@ +# Plan for 2024-11-03 + +SKIP 1 - Import latest approval test +WIP 2 - Run mypi + +Jay - I want to work on projects that don't requre tribal knowledge. +Anti-pattern: Offer change (without test). Assume Llewellyn will accept it. + + + +WIP - Option +- Create a bash script (named 'test_issue_179') that exercises problem. +- Demonstrates the problem +- later... figure where to put it as a test + + +Diana +1 - Do not commit the tox changes in the starter project + Good catch. I did not commit them, but here is the diff to apply to a future starter project + +```diff +diff --git a/tox.ini b/tox.ini +index b2c52fb..2c86f56 100644 +--- a/tox.ini ++++ b/tox.ini +@@ -9,5 +9,8 @@ deps = -rrequirements.txt + + [testenv:dev] + usedevelop = True +-commands = +- ++commands = ++ mypy . ++deps = ++ -rrequirements.txt ++ mypy + +``` + +DONE 2 - Change python3 to be correct python for environment + - Vote for don't care diff --git a/test_issue_179 b/test_issue_179 new file mode 100644 index 0000000..766a19b --- /dev/null +++ b/test_issue_179 @@ -0,0 +1,41 @@ +#! /bin/bash +set -euo pipefail +set -xv + + +# script_dir=$(dirname "$0") +script_dir=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) + + + +# Producer of package... +# Not in venv to create package +rm -rf dist +python3 setup.py sdist bdist_wheel + +# Consumer of package... + +# TODO +# - Cleanup this directory +# - cd back to original directory + + + +temp_dir=$(mktemp --directory) +cd "$temp_dir" + +python3 -m venv .venv +. ./.venv/bin/activate +pip install mypy + + + +pip install "${script_dir}/dist/approvaltests-14.0.0-py3-none-any.whl" + + +# TODO +# - Import approval utilities +# - make sub-something works -- 'import approvaltests.xxxxx' + +echo "import approvaltests" > test.py +mypy test.py From 05dbd57c6007e882d072f7620f1b6a95dc770617 Mon Sep 17 00:00:00 2001 From: "Michael R. Wolf" Date: Sun, 3 Nov 2024 19:08:56 -0500 Subject: [PATCH 2/2] Create 2024-11-03-retro.md Co-Authored-By: Jay Bazuzi Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com> Co-Authored-By: Susan Fung <38925660+susanfung@users.noreply.github.com> --- mob-sessions-retros/2024-11-03-retro.md | 53 +++++++++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 mob-sessions-retros/2024-11-03-retro.md diff --git a/mob-sessions-retros/2024-11-03-retro.md b/mob-sessions-retros/2024-11-03-retro.md new file mode 100644 index 0000000..708ed3e --- /dev/null +++ b/mob-sessions-retros/2024-11-03-retro.md @@ -0,0 +1,53 @@ +# Retro + +## Susan + +Learned - I have a better understanding of how to write a bash +script. I wrote it the first time but I didn’t fully understand it +then. Now I have a better understanding. + +Felt - I was a bit distracted at the beginning but as with all mobs, +once I jump in, I was still able to follow along. Sometimes I feel +like I don’t need to understand the WHOLE problem to be able to follow +along. + + +## Jay +learned +- how to create package +- how to use a local package + +Trtied to do "rear admiral" (navigate the navigator). It worked for a +while. Was trying to be highest (of 3) levels, letting Jay+Diana deal +with details (as Michael typed). + + +Probably don't have enough for next week unless all 4 of us show up. +The shared-in-the-headspace gave us momentum. Goldilocks -- not too +much, maybe too little, probably just-right-for-the-context. + +Back at work, has a work-around. Less than optimal. Can NOT continue +using the broken module (nor as a producer). + +## Diana + +Feels great about way in which Diana participated in mob w/ Jay (even +without rotation). Often collaborated w/ Jay in way that she feels +added value. + +Example - +- Spealing 'directcary' corecktly. How? Translation of talker. Into + lower level How->what actions. + + + +## Michael +- Jay being silent at beginning was an "offer" (in sense of improv) + for someone to step up. Diana did it. Reluctantly and awkwardly at + first. Then it kept getting better on all fronts. Confidence and + compitence showed on her face. + +- Nice offer to have MobbingPattern of "OneTypist". + +- I loved having my own ~/.emacs under my fingers. It was pure joy to + type for group.