Skip to content

PICs are broken #369

@loreloc

Description

@loreloc

The PICs implementation is currently broken.
This can be seen by trying to run the PICs notebook.

It looks like the reason is a recent commit introducing a PyTorch optimization of chained sum layers, where parameter matrices are contracted. See 0d68393.

The torch compiled circuits should be treated as immutable objects, thus they should not be manipulated directly. Changes in the compilation or optimization will often break algorithms operating on compiled circuits that assume the presence of certain layers or parameterizations.

This problem with PICs can be fixed by re-writing the implementation as to operate on symbolic circuits, likely in conjunction with conditional symbolic circuits. See #354.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions