Skip to content

Commit 979b2de

Browse files
authored
Fix lint (#19)
* VotingAggregator: create linting config * ContractUtils: create linting config * chore: use broader scope wildcard for lerna scripts
1 parent 2e78918 commit 979b2de

File tree

6 files changed

+52
-3
lines changed

6 files changed

+52
-3
lines changed

apps/voting-aggregator/.soliumignore

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

apps/voting-aggregator/.soliumrc.json

+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
{
2+
"extends": "solium:all",
3+
"rules": {
4+
"imports-on-top": ["error"],
5+
"variable-declarations": ["error"],
6+
"array-declarations": ["error"],
7+
"operator-whitespace": ["error"],
8+
"lbrace": ["error"],
9+
"mixedcase": 0,
10+
"camelcase": ["error"],
11+
"uppercase": 0,
12+
"no-empty-blocks": ["error"],
13+
"no-unused-vars": ["error"],
14+
"quotes": ["error"],
15+
"indentation": 0,
16+
"whitespace": ["error"],
17+
"deprecated-suicide": ["error"],
18+
"arg-overflow": ["error", 8],
19+
"pragma-on-top": ["error"],
20+
"security/enforce-explicit-visibility": ["error"],
21+
"error-reason": 0
22+
}
23+
}

package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@
1515
"bootstrap:ci": "npm run bootstrap -- --no-ci",
1616
"clean": "git clean -fdxi apps",
1717
"test": "npm run test:all",
18-
"test:all": "lerna run --scope=@aragonone/apps-* --scope=@aragonone/voting-connectors-* --concurrency=1 --stream test",
18+
"test:all": "lerna run --scope=@aragonone/* --concurrency=1 --stream test",
1919
"test:token-wrapper": "lerna run --scope=@aragonone/apps-token-wrapper --stream test",
2020
"test:voting-aggregator": "lerna run --scope=@aragonone/apps-voting-aggregator --stream test",
2121
"test:shared": "lerna run --scope=@aragonone/voting-connectors-* --stream test",
2222
"coverage": "npm run coverage:all",
23-
"coverage:all": "lerna run --scope=@aragonone/apps-* --scope=@aragonone/voting-connectors-* --concurrency=1 --stream coverage",
23+
"coverage:all": "lerna run --scope=@aragonone/* --concurrency=1 --stream coverage",
2424
"coverage:token-wrapper": "lerna run --scope=@aragonone/apps-token-wrapper --stream coverage",
2525
"coverage:voting-aggregator": "lerna run --scope=@aragonone/apps-voting-aggregator --stream coverage",
2626
"coverage:shared": "lerna run --scope=@aragonone/voting-connectors-* --stream coverage",
27-
"lint": "lerna run --scope=@aragonone/apps-* lint"
27+
"lint": "lerna run --scope=@aragonone/* lint"
2828
}
2929
}

shared/contract-utils/.soliumignore

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

shared/contract-utils/.soliumrc.json

+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
{
2+
"extends": "solium:all",
3+
"rules": {
4+
"imports-on-top": ["error"],
5+
"variable-declarations": ["error"],
6+
"array-declarations": ["error"],
7+
"operator-whitespace": ["error"],
8+
"lbrace": ["error"],
9+
"mixedcase": 0,
10+
"camelcase": ["error"],
11+
"uppercase": 0,
12+
"no-empty-blocks": ["error"],
13+
"no-unused-vars": ["error"],
14+
"quotes": ["error"],
15+
"indentation": 0,
16+
"whitespace": ["error"],
17+
"deprecated-suicide": ["error"],
18+
"arg-overflow": ["error", 8],
19+
"pragma-on-top": ["error"],
20+
"security/enforce-explicit-visibility": ["error"],
21+
"error-reason": 0
22+
}
23+
}

shared/contract-utils/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
],
1414
"scripts": {
1515
"compile": "truffle compile",
16+
"lint": "solium --dir ./contracts",
1617
"test": "TRUFFLE_TEST=true npm run ganache-cli:test",
1718
"coverage": "SOLIDITY_COVERAGE=true npm run ganache-cli:test",
1819
"ganache-cli:test": "./node_modules/@aragon/test-helpers/ganache-cli.sh",

0 commit comments

Comments
 (0)