Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Merging splats and applying transformations on export #39

Closed
hybridherbst opened this issue Oct 18, 2023 · 4 comments
Closed

Tools: Merging splats and applying transformations on export #39

hybridherbst opened this issue Oct 18, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@hybridherbst
Copy link
Contributor

From my tests with the current tooling here's two ideas on how to make it even better:

  1. a common usecase I see is downloading a .ply, correcting the transformation, cropping to a nice area and then exporting again. Currently, the transformation correction is not "baked" into the exported file – that would be nice.

  2. combining and composing splats into a new one – currently this can be done manually by copy-pasting lines in PLY files, but would be nice if there would be a single step of exporting a "root" object and then all SplatRenderers + their transformations + their cutoffs and edits would be applied into a single one.

Point (2) would also be a useful optimization for runtime use: the resulting splat would be sorted properly and the data is smaller than shipping multiple splats. Could theoretically even be a build step if someone wants that! (Work at "High" resolution with any number of splats and at build time select ones are baked back into one splat at "Low" resolution)

@aras-p
Copy link
Owner

aras-p commented Oct 18, 2023

Yeah. All of that is Pretty Easy™, except properly rotating the spherical harmonics. Which is also doable, but is not like three lines of code.

@aras-p aras-p added the enhancement New feature or request label Oct 18, 2023
@aras-p aras-p changed the title Merging splats and applying transformations on export Tools: Merging splats and applying transformations on export Oct 18, 2023
@JanaldoChen
Copy link

Yeah. All of that is Pretty Easy™, except properly rotating the spherical harmonics. Which is also doable, but is not like three lines of code.

Have you accomplished the function of rotation of the spherical harmonics? I also struggle with the rotation of SH, if only rotate the xyz and rotation of gaussian splats, it will get worse rendering results.

@aras-p
Copy link
Owner

aras-p commented Oct 19, 2023

Have you accomplished the function of rotation of the spherical harmonics?

Not yet. I'll probably look into using something like https://github.com/andrewwillmott/sh-lib soon (no idea if it's correct or whether it works at all, but unlike most code out there it supports 4th SH order, and does not depend on huge external math libraries)

@aras-p
Copy link
Owner

aras-p commented Nov 9, 2023

Done in #51! Seems To Work ™️ for me, including SH rotation.

@aras-p aras-p closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants