Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When I add a user to a group, it is remove from all other groups #901

Closed
tcoupin opened this issue Oct 20, 2023 · 1 comment · Fixed by #907
Closed

When I add a user to a group, it is remove from all other groups #901

tcoupin opened this issue Oct 20, 2023 · 1 comment · Fixed by #907
Assignees
@zak39
Labels
frontend Modification related to frontend major bug Should be treated first, the application can't run without this

Comments

@tcoupin
Copy link

tcoupin commented Oct 20, 2023 •
edited
Loading

Hi,

I notice a strange behavior.
Having a user "bob" in the group "teamA", when I add him to group "teamB", he is remove from "teamA".

  • Search query for user (it appears multiple time due to oidc Prevent duplicate users_oidc #892)
    Capture d’écran 2023-10-20 à 10 42 35

  • The user is removed from workspace (why???)
    Capture d’écran 2023-10-20 à 10 42 27

  • And then he is added to the new group
    Capture d’écran 2023-10-20 à 10 42 42

This behavior is very dangerous, expetially for workspace managers who leave the WM group.

Nextcloud: 25.0.12
Workspace: 3.0.2
@zak39 zak39 added frontend Modification related to frontend major bug Should be treated first, the application can't run without this labels Nov 15, 2023
@zak39 zak39 self-assigned this Nov 15, 2023
zak39 added a commit that referenced this issue Nov 15, 2023
@zak39
fix(vue): Don't remove an user from a subgroup
a879120 
I deleted an old code which deletes an user as soon as him/her is added to
another a subgroup.

Resolve this issue: #901

Signed-off-by: Baptiste Fotia <[email protected]>
@zak39 zak39 mentioned this issue Nov 15, 2023
Merged
@zak39
Copy link
Collaborator

zak39 commented Nov 15, 2023

Hi @tcoupin ,

I'm sorry for the late reply. I found a fix and we will check if everything is OK

@zak39 zak39 linked a pull request Nov 15, 2023 that will close this issue
Don't remove an user from a subgroup #907
Merged
zak39 added a commit that referenced this issue Nov 22, 2023
@zak39
fix(vue): Don't remove an user from a subgroup
8fc0ed8 
I deleted an old code which deletes an user as soon as him/her is added to
another a subgroup.

Resolve this issue: #901

Signed-off-by: Baptiste Fotia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zak39 zak39

Labels
frontend Modification related to frontend major bug Should be treated first, the application can't run without this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't remove an user from a subgroup arawa/workspace
2 participants
@tcoupin @zak39