Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Organise models folders #1445

Closed
dartpain opened this issue Nov 17, 2024 · 4 comments · Fixed by #1603
Closed

Feat: Organise models folders #1445

dartpain opened this issue Nov 17, 2024 · 4 comments · Fixed by #1603
Labels
application Application backend extensions Extensions good first issue Good for newcomers help wanted Extra attention is needed python Pull requests that update Python code

Comments

@dartpain
Copy link
Contributor

We have two folder model and models they are used for storing embedding models and llms respectively.
Use one folder for both instead (models)

To complete this feature you will need to look for all uses for model / models folder and make sure you check all install scripts that may be using them
@dartpain dartpain added good first issue Good for newcomers help wanted Extra attention is needed python Pull requests that update Python code application Application extensions Extensions backend labels Nov 17, 2024
@piyush7833
Copy link

can this be assigned to me? thanks. @dartpain

@piyush7833
Copy link

Hi @dartpain, I found the llms folder, but I’m unable to locate the model or models folder. Could you please help me navigate to these folders?

@dartpain
Copy link
Contributor Author

Here we use one of the folders to store gguf model file temporarily
https://github.com/arc53/DocsGPT/blob/main/setup.sh

We also download embeddings model here in Dockerfile
https://github.com/arc53/DocsGPT/blob/main/application/Dockerfile
And retrieve it here:
https://github.com/arc53/DocsGPT/blob/main/application/vectorstore/base.py

@ManishMadan2882
Copy link
Collaborator

@piyush7833 Just checking if you are active on this issue

@dartpain dartpain moved this to Todo in DocsGPT Roadmap Dec 22, 2024
Mike014 added a commit to Mike014/DocsGPT that referenced this issue Jan 25, 2025
@Mike014
Fixing issues arc53#1445
270c00e
@Mike014 Mike014 mentioned this issue Jan 25, 2025
Merged
@dartpain dartpain linked a pull request Jan 25, 2025 that will close this issue
Fixing issues #1445 #1603
Merged
@dartpain dartpain moved this from Todo to In Progress in DocsGPT Roadmap Jan 25, 2025
Mike014 added a commit to Mike014/DocsGPT that referenced this issue Feb 5, 2025
@Mike014
Fixed issue arc53#1445
21cf36e
dartpain pushed a commit that referenced this issue Feb 5, 2025
@Mike014
Fixing issues #1445 (#1603)
2f78398 
* Fixing issues #1445

* Fixed issue #1445
@github-project-automation github-project-automation bot moved this from In Progress to Done in DocsGPT Roadmap Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
application Application backend extensions Extensions good first issue Good for newcomers help wanted Extra attention is needed python Pull requests that update Python code
Projects
DocsGPT Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing issues #1445 Mike014/DocsGPT
3 participants
@dartpain @ManishMadan2882 @piyush7833